Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685998 - net-analyzer/bwping: fix tests with FEATURES=userpriv, fix HOMEPAGE
Summary: net-analyzer/bwping: fix tests with FEATURES=userpriv, fix HOMEPAGE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-14 22:34 UTC by Oleg Derevenetz
Modified: 2019-05-15 07:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
bwping-1.14.ebuild (bwping-1.14.ebuild,493 bytes, text/plain)
2019-05-14 22:34 UTC, Oleg Derevenetz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Derevenetz 2019-05-14 22:34:32 UTC
Created attachment 576706 [details]
bwping-1.14.ebuild

Hi,

Please look at attached bwping-1.14.ebuild with the following changes:

- RESTRICT="test" was removed, check for userpriv in FEATURES has been implemented instead;
- HTTPS-enabled SourceForge-hosted websites are in .io domain, not in .net, and it seems that .net -> .io redirect doesn't work for them, so HOMEPAGE has been updated accordingly.

With best regards, Oleg.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-05-15 06:56:51 UTC
Comment on attachment 576706 [details]
bwping-1.14.ebuild

># Copyright 1999-2019 Gentoo Authors
># Distributed under the terms of the GNU General Public License v2
>
>EAPI=7
>
>DESCRIPTION="A tool to measure bandwidth and RTT between two hosts using ICMP"
>HOMEPAGE="https://bwping.sourceforge.io/"

OK, I'll change that.

>SRC_URI="mirror://sourceforge/${PN}/${PV}/${P}.tar.gz"
>
>LICENSE="BSD"
>SLOT="0"
>KEYWORDS="~amd64 ~sparc ~x86 ~x86-fbsd"
>
>src_test() {
>	if has userpriv ${FEATURES} ; then

I am sorry, but last I looked, checking for FEATURES in ebuilds is not allowed.
Comment 2 Larry the Git Cow gentoo-dev 2019-05-15 06:58:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=12002fb28bed174428ef1e08b1dd2386728e9394

commit 12002fb28bed174428ef1e08b1dd2386728e9394
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-05-15 06:57:29 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-05-15 06:58:03 +0000

    net-analyzer/bwping: Update HOMEPAGE
    
    Package-Manager: Portage-2.3.66, Repoman-2.3.12
    
    Bug: https://bugs.gentoo.org/685998
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-analyzer/bwping/bwping-1.14.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Larry the Git Cow gentoo-dev 2019-05-15 07:05:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=162051b07100583bcd1004d4535ee3a1468104a5

commit 162051b07100583bcd1004d4535ee3a1468104a5
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-05-15 07:05:07 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-05-15 07:05:32 +0000

    net-analyzer/bwping: Enable test phase, check UID
    
    Package-Manager: Portage-2.3.66, Repoman-2.3.12
    Fixes: https://bugs.gentoo.org/685998
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-analyzer/bwping/bwping-1.14.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)