Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685914 - kde5.eclass (EAPI="7"): Misplaced dependencies on dev-util/desktop-file-utils and app-arch/xz-utils
Summary: kde5.eclass (EAPI="7"): Misplaced dependencies on dev-util/desktop-file-utils...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All All
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-14 03:43 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-07-04 19:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-05-14 03:43:06 UTC
In EAPI="7", kde5.eclass adds dependencies on dev-util/desktop-file-utils and app-arch/xz-utils to DEPEND, but both of them are used here only as tools, and should be in BDEPEND.


(app-arch/xz-utils has been in @system set (since 2011-03-02 13:23:24 UTC), so explicit depending on it (when used only as unpacker, not when linking against liblzma.so) is not really necessary...)
Comment 1 Larry the Git Cow gentoo-dev 2019-05-16 09:17:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=70a6870c9a52bde808430f2ae48bc4531c051d80

commit 70a6870c9a52bde808430f2ae48bc4531c051d80
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2019-05-16 09:16:35 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2019-05-16 09:17:09 +0000

    kde5.eclass: remove app-arch/xz-utils DEPEND
    
    It was only ever added for unpacking, and it appears in @system now.
    
    Bug: https://bugs.gentoo.org/685914

 eclass/kde5.eclass | 2 --
 1 file changed, 2 deletions(-)
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-05-16 18:55:53 UTC
Actually I suggest to drop direct dependency on dev-util/desktop-file-utils in kde5.eclass.
Executables from dev-util/desktop-file-utils are not used directly in kde5.eclass.
kde5.eclass inherits xdg.eclass and calls xdg_pkg_preinst(), xdg_pkg_postinst() and xdg_pkg_postrm() functions in relevant phases.
xdg.eclass already adds dependencies on dev-util/desktop-file-utils and x11-misc/shared-mime-info.
xdg.eclass will have to be fixed somehow as explained in bug #685916.

Currently direct dependency on dev-util/desktop-file-utils in kde5.eclass results in dev-util/desktop-file-utils being specified twice in DEPEND of ebuilds which inherit kde5.eclass.
(See e.g. `portageq metadata / ebuild kde-apps/konsole-9999 DEPEND | grep dev-util/desktop-file-utils`)
Comment 3 Larry the Git Cow gentoo-dev 2019-05-18 02:21:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=415e306cd99d2d51e9473fe7e3d3974cf9300e61

commit 415e306cd99d2d51e9473fe7e3d3974cf9300e61
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2019-05-18 02:21:13 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2019-05-18 02:21:41 +0000

    kde5.eclass: remove dev-util/desktop-file-utils dependency
    
    This only ever used indirectly via xdg_pkg_* and xdg.eclass handles the
    dependency as well.
    
    Bug: https://bugs.gentoo.org/685914

 eclass/kde5.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2019-05-18 19:33:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1ed19738119325f293dd2e1180ffd73b945efebf

commit 1ed19738119325f293dd2e1180ffd73b945efebf
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2019-05-16 09:16:35 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-05-18 19:33:25 +0000

    kde5.eclass: remove app-arch/xz-utils DEPEND
    
    It was only ever added for unpacking, and it appears in @system now.
    
    Bug: https://bugs.gentoo.org/685914
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/kde5.eclass | 2 --
 1 file changed, 2 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2019-07-04 19:39:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=102d977cb8e58e04406c8c9cbeac84ed21ed6713

commit 102d977cb8e58e04406c8c9cbeac84ed21ed6713
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2019-05-18 02:21:13 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-07-04 19:39:22 +0000

    kde5.eclass: remove dev-util/desktop-file-utils dependency
    
    This only ever used indirectly via xdg_pkg_* and xdg.eclass handles the
    dependency as well.
    
    Closes: https://bugs.gentoo.org/685914
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/kde5.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)