Created attachment 576034 [details, diff] Patch to remove outdated workarounds The following workaround was being applied to ebuilds using mozcoreconf-v6.eclass to work around bugs in the Firefox codebase (and related software): ~~~ # We need to append flags for gcc-6 support if [[ $(gcc-major-version) -ge 6 ]]; then append-cxxflags -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns -fno-schedule-insns2 fi ~~~ Those bugs have been fixed in the latest versions of Firefox and are no longer necessary. Tested on GCC 9.1.0, amd64 Patch is attached to remove this section of mozcoreconf-v6.eclass.
We may still need -flifetime-dse=1. pgo build shows a bunch of warnings if -fno-lifetime-dse is just removed.
Created attachment 576184 [details, diff] Updated patch to use only -flifetime-dse=1
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b72ad94432f47fb491245964eab9abb9187787ed commit b72ad94432f47fb491245964eab9abb9187787ed Author: Shane Peelar <lookatyouhacker@gmail.com> AuthorDate: 2019-05-12 14:10:31 +0000 Commit: Jory Pratt <anarchy@gentoo.org> CommitDate: 2019-05-13 11:54:49 +0000 mozcoreconf-v6: Remove older workarounds Keep -flifetime-dse=1 as it is required for PGO Closes: https://bugs.gentoo.org/685632 Signed-off-by: Shane Peelar <lookatyouhacker@gmail.com> Signed-off-by: Jory Pratt <anarchy@gentoo.org> eclass/mozcoreconf-v6.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
