Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685278 - net-misc/linuxptp uses mantatory kernel config
Summary: net-misc/linuxptp uses mantatory kernel config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-07 15:53 UTC by Paul Stewart
Modified: 2019-05-20 05:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Stewart 2019-05-07 15:53:44 UTC
As I understand it, ebuilds should not consider kernel configs to be mandatory unless this is necessary for building the package itself.  If there is a runtime dependency on a feature (in this case PPS, NETWORK_PHY_TIMESTAMPING and PTP_1588_CLOCK) these can be defined as advisory instead.
Comment 1 Paul Stewart 2019-05-07 16:12:58 UTC
Proposed fix is in pull request commit: https://github.com/gentoo/gentoo/pull/11566/commits/ed84fc343d098bab030167d0dd1e9ff722a30c7e
Comment 2 Larry the Git Cow gentoo-dev 2019-05-20 05:18:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e71ee81acf44dbf10d228da268024ce9873996be

commit e71ee81acf44dbf10d228da268024ce9873996be
Author:     Thomas Beierlein <tomjbe@gentoo.org>
AuthorDate: 2019-05-20 05:18:07 +0000
Commit:     Thomas Beierlein <tomjbe@gentoo.org>
CommitDate: 2019-05-20 05:18:07 +0000

    net-misc/linuxptp: Make kernel config advisory
    
    Reported-by: Paul Steward <pstew@google.com>
    Closes: https://bugs.gentoo.org/685278
    Closes: https://github.com/gentoo/gentoo/pull/11566
    Package-Manager: Portage-2.3.66, Repoman-2.3.12
    Signed-off-by: Thomas Beierlein <tomjbe@gentoo.org>

 net-misc/linuxptp/linuxptp-1.8.ebuild | 4 ++--
 net-misc/linuxptp/linuxptp-2.0.ebuild | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)