Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 685020 - sys-libs/libblockdev should conditionally depend on dev-libs/gobject-introspection
Summary: sys-libs/libblockdev should conditionally depend on dev-libs/gobject-introspe...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-04 04:47 UTC by Gino McCarty
Modified: 2022-06-29 08:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gino McCarty 2019-05-04 04:47:45 UTC
libblockdev doesn't actually require gobject-introspection, its only needed for gnome based environments
here is an ebuild patch to use the "introspection" use flag.. This flag is pretty common in portage tree

===========================
--- /usr/portage/sys-libs/libblockdev/libblockdev-2.20-r2.ebuild        2019-04-17 19:35:38.448918238 -0700
+++ /usr/local/portage/sys-libs/libblockdev/libblockdev-2.20-r2.ebuild  2019-05-03 21:06:36.467237755 -0700
@@ -15,7 +15,7 @@
 LICENSE="LGPL-2+"
 SLOT="0"
 KEYWORDS="alpha amd64 arm arm64 ~ia64 ~mips ppc ppc64 sparc x86"
-IUSE="bcache +cryptsetup device-mapper dmraid doc escrow lvm kbd test vdo"
+IUSE="bcache +cryptsetup device-mapper dmraid doc escrow introspection lvm kbd test vdo"

 RDEPEND="
        >=dev-libs/glib-2.42.2
@@ -47,7 +47,7 @@
        ${RDEPEND}
 "
 BDEPEND="
-       >=dev-libs/gobject-introspection-1.3.0
+       introspection? ( >=dev-libs/gobject-introspection-1.3.0 )
        sys-devel/autoconf-archive
        doc? ( dev-util/gtk-doc )
 "
@@ -74,6 +74,7 @@
                --with-part
                --without-mpath
                --without-nvdimm
+               $(use_enable introspection)
                $(use_enable test tests)
                $(use_with bcache)
                $(use_with cryptsetup crypto)
==========================================================
Comment 1 Larry the Git Cow gentoo-dev 2019-06-17 14:36:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6e87617f23a8b2bd9f0b3bc3203ef79b400cc081

commit 6e87617f23a8b2bd9f0b3bc3203ef79b400cc081
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-06-17 14:35:50 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-06-17 14:35:50 +0000

    sys-libs/libblockdev: Added "introspection" USE flag to live ebuild
    
    Thanks-to: Gino McCarty <onigino@protonmail.com>
    Bug: https://bugs.gentoo.org/685020
    Package-Manager: Portage-2.3.67, Repoman-2.3.14
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-libs/libblockdev/libblockdev-9999.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-06-17 14:37:45 UTC
Sorry it took so long to make it into an ebuild. I've added your suggested changes into the live ebuild and will move that into the next upstream release ebuild as well.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-29 08:36:15 UTC
$ grep -rsin "gobject"
libblockdev-2.26.ebuild:65:     introspection? ( >=dev-libs/gobject-introspection-1.3.0 )
libblockdev-2.27.ebuild:65:     introspection? ( >=dev-libs/gobject-introspection-1.3.0 )
libblockdev-9999.ebuild:65:     introspection? ( >=dev-libs/gobject-introspection-1.3.0 )