Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 684994 - games-fps/doomsday-2.0.3 and games-fps/eduke32-20190419.615[tools] have a file collision at /usr/bin/md2tool
Summary: games-fps/doomsday-2.0.3 and games-fps/eduke32-20190419.615[tools] have a fil...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-05-03 18:34 UTC by Patrick McMunn
Modified: 2019-05-04 09:14 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick McMunn 2019-05-03 18:34:41 UTC
If eduke32 is installed with the tools USE flag enabled, it installs /usr/bin/md2tool. Doomsday should only install /usr/bin/md2tool if the tools USE flag is enabled, but for some reason it still installs this file even if the tools USE flag is disabled. So if eduke32 is installed with the tools USE flag enabled, attempting to install Doomsday results in a file collision regardless of whether it has the USE flag enabled.

The current workaround is to disable the tools USE flag for eduke32, but it still remains that Doomsday wrongly installs this file even when the tools USE flag is disabled. At the very least, this should be fixed. But even if that were resolved, a file collision would still result if both ebuilds were emerged with the tools USE flag enabled.
Comment 1 Conrad Kostecki gentoo-dev 2019-05-03 20:28:37 UTC
The tools use flag seems to be a noop, as it only pulls ncuseses as a dep, but doesn't to anything in configure time. This would explain your behavior.

Despite its not my package, I will look into, and try also to bump directly to 2.1.1 :-)
Comment 2 Conrad Kostecki gentoo-dev 2019-05-03 21:23:04 UTC
Added PR.
Bumped to 2.1.1, added cmake build option for tools and added a blocker against games-fps/eduke32[tools].
Comment 3 James Le Cuirot gentoo-dev 2019-05-03 21:34:22 UTC
Blockers should be avoided, if possible. Could you just rename md2tool in one or both packages? Maybe add a pkg_postinst note about it.
Comment 4 Conrad Kostecki gentoo-dev 2019-05-03 22:07:45 UTC
(In reply to James Le Cuirot from comment #3)
> Blockers should be avoided, if possible. Could you just rename md2tool in
> one or both packages? Maybe add a pkg_postinst note about it.

Okay. I've renamed now md2tool to md2tool.doomsday, see PR.
I also would rename md2tool to md2tool.eduke32 from games-fps/eduke32, but on next version bump, if this is okay for you?
Comment 5 Larry the Git Cow gentoo-dev 2019-05-04 09:14:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6bc6b47ba7d22ecda0c8e4cc7b54070a6f751ba

commit e6bc6b47ba7d22ecda0c8e4cc7b54070a6f751ba
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-05-03 21:21:25 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-05-04 09:13:44 +0000

    games-fps/doomsday: bump to version 2.1.1
    
    Also fixed file collision with games-fps/eduke32[tools].
    
    Closes: https://bugs.gentoo.org/684994
    Package-Manager: Portage-2.3.65, Repoman-2.3.12
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/11888
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-fps/doomsday/Manifest              |   1 +
 games-fps/doomsday/doomsday-2.1.1.ebuild | 100 +++++++++++++++++++++++++++++++
 2 files changed, 101 insertions(+)