Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 684294 - net-misc/freerdp-2.0.0_rc4 with dev-libs/libressl-2.9.1 : /.../tls.c:1048:15: error: struct ssl3_state_st has no member named alert_dispatch
Summary: net-misc/freerdp-2.0.0_rc4 with dev-libs/libressl-2.9.1 : /.../tls.c:1048:15:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-24 18:36 UTC by Toralf Förster
Modified: 2019-09-29 20:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.33 KB, text/plain)
2019-04-24 18:36 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,291.17 KB, text/plain)
2019-04-24 18:36 UTC, Toralf Förster
Details
environment (environment,111.79 KB, text/plain)
2019-04-24 18:36 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,16.27 KB, application/x-bzip)
2019-04-24 18:36 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,8.91 KB, application/x-bzip)
2019-04-24 18:36 UTC, Toralf Förster
Details
net-misc:freerdp-2.0.0_rc4:20190424-075120.log (net-misc:freerdp-2.0.0_rc4:20190424-075120.log,309.20 KB, text/plain)
2019-04-24 18:36 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,34.62 KB, application/x-bzip)
2019-04-24 18:36 UTC, Toralf Förster
Details
freerdp-libre291.patch (libre-freerdp.patch,617 bytes, patch)
2019-04-25 21:44 UTC, pagorman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-04-24 18:36:35 UTC
      ^~~~~~~~~~~~
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/libfreerdp/crypto/tls.c: In function ‘tls_send_alert’:
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/libfreerdp/crypto/tls.c:1048:15: error: ‘struct ssl3_state_st’ has no member named ‘alert_dispatch’
   tls->ssl->s3->alert_dispatch = 1;
               ^~
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/libfreerdp/crypto/tls.c:1049:15: error: ‘struct ssl3_state_st’ has no member named ‘send_alert’

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_libressl_20190417-202422

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-8.3.0 *

Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.6
  [3]   python2.7 (fallback)
  [4]   pypy (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems) *
  [2]   ruby25 (with Rubygems)
  [3]   ruby26 (with Rubygems)
Available Rust versions:
  [1]   rust-1.34.0 *



emerge -qpvO net-misc/freerdp
[ebuild   R   ] net-misc/freerdp-2.0.0_rc4  USE="client libressl -X -alsa -cups -debug -doc -ffmpeg -gstreamer -jpeg -libav (-neon) -openh264 -pulseaudio -server -smartcard -systemd -test -usb -wayland -xinerama -xv"
Comment 1 Toralf Förster gentoo-dev 2019-04-24 18:36:38 UTC
Created attachment 574014 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2019-04-24 18:36:40 UTC
Created attachment 574016 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2019-04-24 18:36:43 UTC
Created attachment 574018 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2019-04-24 18:36:46 UTC
Created attachment 574020 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2019-04-24 18:36:49 UTC
Created attachment 574022 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2019-04-24 18:36:52 UTC
Created attachment 574024 [details]
net-misc:freerdp-2.0.0_rc4:20190424-075120.log
Comment 7 Toralf Förster gentoo-dev 2019-04-24 18:36:54 UTC
Created attachment 574026 [details]
temp.tbz2
Comment 8 pagorman 2019-04-25 21:44:39 UTC
Created attachment 574162 [details, diff]
freerdp-libre291.patch

well, some small set of compatibility bindings inside LibreSSL caught up to OpenSSL again. Had to update "defined(LIBRESSL_VERSION_NUMBER)" to "LIBRESSL_VERSION_NUMBER < 0x2090000f" and expand the logic to avoid the confusion the compiler will have with undefined (LIBRE/OPEN)SSL_VERSION_NUMBER variables.

Time to talk to upstream again.
Comment 9 pagorman 2019-04-25 21:47:24 UTC
Looks like upstream has already caught the issue in their master branch. This patchfile still works.
Comment 10 Mike Gilbert gentoo-dev 2019-04-25 21:52:16 UTC
If you link me to the upstream commits, I will backport them. Otherwise, I'll just wait for the next release candidate.
Comment 11 Stefan Strogin gentoo-dev 2019-08-28 16:32:30 UTC
(In reply to Mike Gilbert from comment #10)
> If you link me to the upstream commits, I will backport them. Otherwise,
> I'll just wait for the next release candidate.

Here it is: https://github.com/FreeRDP/FreeRDP/commit/0c83efa753d0457eb319624f87b491badf75105f

Works for me.
Comment 12 Larry the Git Cow gentoo-dev 2019-09-29 20:48:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b4e5c994bbd5233a937240df9a3ff6c522703ac

commit 6b4e5c994bbd5233a937240df9a3ff6c522703ac
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2019-09-29 20:48:11 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-09-29 20:48:11 +0000

    net-misc/freerdp: another libressl fix
    
    Closes: https://bugs.gentoo.org/684294
    Package-Manager: Portage-2.3.75_p7, Repoman-2.3.17_p49
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-misc/freerdp/files/2.0.0-rc4-libressl.patch | 31 +++++++++++++++++++++++++
 1 file changed, 31 insertions(+)