Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 684286 - app-office/gnucash-3.3 - .../work/gnucash-3.3/gnucash/gnome-utils/gnc-tree-view-split-reg.c:1524:13: error: ‘strncpy’ specified bound 35 equals destination size [-Werror=stringop-truncation]
Summary: app-office/gnucash-3.3 - .../work/gnucash-3.3/gnucash/gnome-utils/gnc-tree-vi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Aaron W. Swenson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-04-24 18:26 UTC by Alec Ten Harmsel
Modified: 2019-05-21 13:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (app-office:gnucash-3.3:20190424-184813.log,695.24 KB, text/x-log)
2019-04-24 18:53 UTC, Alec Ten Harmsel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Ten Harmsel 2019-04-24 18:26:38 UTC
Due to the presence of -Werror, gnucash-3.3 fails to build for me with GCC 8.2.0:

> /var/tmp/portage/app-office/gnucash-3.3/work/gnucash-3.3/gnucash/gnome-utils/gnc-tree-view-split-reg.c:1524:13: error: ‘strncpy’ specified bound 35 equals destination size [-Werror=stringop-truncation]                                                                                                                    
>             strncpy (datebuff,  _(" Scheduled "), sizeof(datebuff));
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-04-24 18:35:45 UTC
Please attach the entire build log to this bug report.
Comment 2 Alec Ten Harmsel 2019-04-24 18:53:42 UTC
Created attachment 574076 [details]
build log

Here's the build log - sorry I forgot it initially. I also have a PR open on GitHub (https://github.com/gentoo/gentoo/pull/11817) that I tested locally.
Comment 3 Larry the Git Cow gentoo-dev 2019-05-21 13:52:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7c7ccd0f43b62f064d6d0bb57186db7cf6ddd18

commit d7c7ccd0f43b62f064d6d0bb57186db7cf6ddd18
Author:     Alec Ten Harmsel <alec@alectenharmsel.com>
AuthorDate: 2019-04-24 18:30:21 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2019-05-21 13:52:26 +0000

    app-office/gnucash: Append -Wno-error for 3.3+
    
    GCC 8.3.0 issues some warnings for Gnucash 3.3+, causing build failures.
    
    Package-Manager: Portage-2.3.62, Repoman-2.3.11
    Signed-off-by: Alec Ten Harmsel <alec@alectenharmsel.com>
    Closes: https://bugs.gentoo.org/684286
    Closes: https://github.com/gentoo/gentoo/pull/11817
    Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org>

 app-office/gnucash/gnucash-3.3-r1.ebuild | 4 +++-
 app-office/gnucash/gnucash-3.3.ebuild    | 4 +++-
 app-office/gnucash/gnucash-3.4.ebuild    | 4 +++-
 app-office/gnucash/gnucash-3.5.ebuild    | 2 +-
 4 files changed, 10 insertions(+), 4 deletions(-)