Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683910 - dev-python/twisted-18.7.0 incorrectly marked as Python 3.7 compatible
Summary: dev-python/twisted-18.7.0 incorrectly marked as Python 3.7 compatible
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-04-20 18:20 UTC by Chris Mayo
Modified: 2020-02-22 20:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2019-04-20 18:20:32 UTC
Fix released in Twisted 18.9.0

https://github.com/twisted/twisted/blob/twisted-19.2.0/NEWS.rst#twisted-1890-2018-10-10


/usr/bin/python3.7 /var/tmp/portage/dev-python/twisted-18.7.0/temp/tmp1n9rdxq6.py
  File "/usr/lib/python3.7/site-packages/twisted/conch/manhole.py", line 154
    def write(self, data, async=False):
                              ^
SyntaxError: invalid syntax

  File "/usr/lib/python3.7/site-packages/twisted/mail/imap4.py", line 1093
    def sendUntaggedResponse(self, message, async=False):
                                                ^
SyntaxError: invalid syntax

removing /var/tmp/portage/dev-python/twisted-18.7.0/temp/tmp1n9rdxq6.py
writing byte-compilation script '/var/tmp/portage/dev-python/twisted-18.7.0/temp/tmpr67l91ip.py'
/usr/bin/python3.7 /var/tmp/portage/dev-python/twisted-18.7.0/temp/tmpr67l91ip.py
  File "/usr/lib/python3.7/site-packages/twisted/conch/manhole.py", line 154
    def write(self, data, async=False):
                              ^
SyntaxError: invalid syntax

  File "/usr/lib/python3.7/site-packages/twisted/mail/imap4.py", line 1093
    def sendUntaggedResponse(self, message, async=False):
                                                ^
SyntaxError: invalid syntax
Comment 1 Chris Mayo 2019-04-20 18:29:40 UTC
Or maybe not, the async fix (attempt 1) appears to be here;
https://github.com/twisted/twisted/commit/dcaf946217b4ea1684e98a9ebc4f9925d76f3108#diff-2484b672d0df51beac14f2c47b28a50d

which is tagged twisted-19.2.0.
Comment 2 Larry the Git Cow gentoo-dev 2019-11-28 03:16:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=538d1343448d7d69ebc75afe857c6601eaa844fa

commit 538d1343448d7d69ebc75afe857c6601eaa844fa
Author:     Aaron Bauman <bman@gentoo.org>
AuthorDate: 2019-11-28 03:01:49 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-11-28 03:16:34 +0000

    dev-python/twisted: bump to 19.10.0
    
    * Remove net-misc/openssh version constraint
    * dev-python/bcrypt is now in DEPEND
    * Drop all patches which are no longer required
    * Clean python_test() per previous comment
    
    Package is still not compatible with py3.8 but is very close. We should see full
    support soon. Most tests pass with py3.8. Additionally, dev-python/automat will
    require a bump to >=0.8.0 in order to support py3.8 within twisted.
    
    Bug: https://bugs.gentoo.org/661258
    Bug: https://bugs.gentoo.org/662340
    Bug: https://bugs.gentoo.org/677226
    Bug: https://bugs.gentoo.org/690790
    Bug: https://bugs.gentoo.org/683910
    
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 dev-python/twisted/Manifest               |   1 +
 dev-python/twisted/twisted-19.10.0.ebuild | 173 ++++++++++++++++++++++++++++++
 2 files changed, 174 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2020-02-22 20:22:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d4ad02e316546762ff4e57a91bd7325437ce15d2

commit d4ad02e316546762ff4e57a91bd7325437ce15d2
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-02-22 15:47:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-02-22 20:22:14 +0000

    dev-python/twisted: Drop 17.1.0-r2, 17.9.0 and 18.7.0
    
    EAPI-5--, 18.7.0 is broken with py37 anyway. Keeping 18.4.0 as the latest
    version with all ~arch support.
    
    Closes: https://bugs.gentoo.org/683910
    Closes: https://bugs.gentoo.org/690790
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-python/twisted/Manifest                 |   3 -
 dev-python/twisted/twisted-17.1.0-r2.ebuild | 186 ---------------------------
 dev-python/twisted/twisted-17.9.0.ebuild    | 191 ---------------------------
 dev-python/twisted/twisted-18.7.0.ebuild    | 192 ----------------------------
 4 files changed, 572 deletions(-)