Bug 683790 – ~sys-devel/binutils-{2.31,2.32}: Backport fix for regression disallowing creation of shared libraries using some symbols (e.g. __ehdr_start) defined in static libraries

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis 2019-04-18 19:44:24 UTC]

Binutils bug:
  https://sourceware.org/bugzilla/show_bug.cgi?id=24458

Fix:
  master branch:
    https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4e84a8f8bbeab52fa7048873655e582ceb92534d
  binutils-2_32-branch branch:
    https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=49364d83d58d6357aa0fcd1b448b48218d244675
"""
x86: Also check x86 linker_def for non-shared definition

Since elf_x86_linker_defined sets linker_def in elf_x86_link_hash_entry
for linker defined symbols, SYMBOL_DEFINED_NON_SHARED_P should also check
linker_def in elf_x86_link_hash_entry.

bfd/

	PR ld/24458
	* elfxx-x86.h (SYMBOL_DEFINED_NON_SHARED_P): Also check x86
	linker_def.

ld/

	PR ld/24458
	* testsuite/ld-x86-64/x86-64.exp: Run PR ld/24458 tests.
	* testsuite/ld-x86-64/pr24458.s: New file.
	* testsuite/ld-x86-64/pr24458a-x32.d: Likewise.
	* testsuite/ld-x86-64/pr24458a.d: Likewise.
	* testsuite/ld-x86-64/pr24458b-x32.d: Likewise.
	* testsuite/ld-x86-64/pr24458b.d: Likewise.
	* testsuite/ld-x86-64/pr24458c-x32.d: Likewise.
	* testsuite/ld-x86-64/pr24458c.d: Likewise.
"""

[Comment 1 Larry the Git Cow 2019-04-18 21:38:21 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a5fff247244e8094595002711d429d4ab08f073

commit 0a5fff247244e8094595002711d429d4ab08f073
Author:     Andreas K. Hüttel <[e-mail]>
AuthorDate: 2019-04-18 21:37:49 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2019-04-18 21:38:15 +0000

    sys-devel/binutils: 2.32 patchlevel bump
    
    Bug: https://bugs.gentoo.org/683790
    Package-Manager: Portage-2.3.63, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 sys-devel/binutils/Manifest                |   1 +
 sys-devel/binutils/binutils-2.32-r1.ebuild | 438 +++++++++++++++++++++++++++++
 2 files changed, 439 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46e02f32cb3a49c669063670a6f0c0c8c68fa12c

commit 46e02f32cb3a49c669063670a6f0c0c8c68fa12c
Author:     Andreas K. Hüttel <[e-mail]>
AuthorDate: 2019-04-18 21:36:20 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2019-04-18 21:38:14 +0000

    sys-devel/binutils-hppa64: 2.32 patchlevel bump
    
    Bug: https://bugs.gentoo.org/683790
    Package-Manager: Portage-2.3.63, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 sys-devel/binutils-hppa64/Manifest                 |   1 +
 .../binutils-hppa64/binutils-hppa64-2.32-r1.ebuild | 441 +++++++++++++++++++++
 2 files changed, 442 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=101fb6c48776f0ca5ffb5f49d2d1b0971a603c4d

commit 101fb6c48776f0ca5ffb5f49d2d1b0971a603c4d
Author:     Andreas K. Hüttel <[e-mail]>
AuthorDate: 2019-04-18 21:33:01 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2019-04-18 21:38:14 +0000

    sys-libs/binutils-libs: 2.32 patchlevel bump
    
    Bug: https://bugs.gentoo.org/683790
    Package-Manager: Portage-2.3.63, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 sys-libs/binutils-libs/Manifest                    |   1 +
 .../binutils-libs/binutils-libs-2.32-r1.ebuild     | 118 +++++++++++++++++++++
 2 files changed, 119 insertions(+)

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-04-24 16:47:10 UTC]

sys-devel/binutils-2.31.1-r4 is not affected, but regression was backported to sys-devel/binutils-2.31.1-r5:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=c83ac8021a7649c148cb344870d8ce711eecc3c6
https://github.com/gentoo/binutils-gdb/commit/0bdfb9ee9ac7a7affa900fdfd8c78645e9c83484

[Comment 3 Arfrever Frehtes Taifersar Arahesis 2019-04-24 20:11:46 UTC]

Fix:
  binutils-2_31-branch branch:
    https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bca6a14c568bd63080c85a6b05c90996e2bd4a34

[Comment 4 Larry the Git Cow 2019-04-25 18:44:40 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5000dff6b746b24a4ca1549273f01bd6d55e76d4

commit 5000dff6b746b24a4ca1549273f01bd6d55e76d4
Author:     Andreas K. Huettel <[e-mail]>
AuthorDate: 2019-04-25 18:42:01 +0000
Commit:     Andreas K. Huettel <[e-mail]>
CommitDate: 2019-04-25 18:42:36 +0000

    sys-libs/binutils-libs: Patchlevel bump
    
    Signed-off-by: Andreas K. Hüttel <[e-mail]>
    Closes: https://bugs.gentoo.org/683790
    Package-Manager: Portage-2.3.64, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 sys-libs/binutils-libs/Manifest                    |   1 +
 .../binutils-libs/binutils-libs-2.31.1-r6.ebuild   | 117 +++++++++++++++++++++
 2 files changed, 118 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d07913c5ad5c66e666511c97d731136470f18c2f

commit d07913c5ad5c66e666511c97d731136470f18c2f
Author:     Andreas K. Huettel <[e-mail]>
AuthorDate: 2019-04-25 18:41:15 +0000
Commit:     Andreas K. Huettel <[e-mail]>
CommitDate: 2019-04-25 18:42:33 +0000

    sys-devel/binutils-hppa64: Patchlevel bump
    
    Signed-off-by: Andreas K. Hüttel <[e-mail]>
    Closes: https://bugs.gentoo.org/683790
    Package-Manager: Portage-2.3.64, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 sys-devel/binutils-hppa64/Manifest                 |   1 +
 .../binutils-hppa64-2.31.1-r6.ebuild               | 443 +++++++++++++++++++++
 2 files changed, 444 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b1e55d1a19d544550e4566faaeb40ec2657315b

commit 2b1e55d1a19d544550e4566faaeb40ec2657315b
Author:     Andreas K. Huettel <[e-mail]>
AuthorDate: 2019-04-25 18:40:31 +0000
Commit:     Andreas K. Huettel <[e-mail]>
CommitDate: 2019-04-25 18:42:31 +0000

    sys-devel/binutils: Patchlevel bump
    
    Signed-off-by: Andreas K. Hüttel <[e-mail]>
    Closes: https://bugs.gentoo.org/683790
    Package-Manager: Portage-2.3.64, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 sys-devel/binutils/Manifest                  |   1 +
 sys-devel/binutils/binutils-2.31.1-r6.ebuild | 437 +++++++++++++++++++++++++++
 2 files changed, 438 insertions(+)