Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 683670 - dev-ruby/asciidoctor-diagram should not force dependency on dev-ruby/asciidoctor-1.5
Summary: dev-ruby/asciidoctor-diagram should not force dependency on dev-ruby/asciidoc...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-04-17 11:58 UTC by Amel Hodzic
Modified: 2019-04-21 06:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Amel Hodzic 2019-04-17 11:58:25 UTC
asciidoctor-diagram defines the dependency on asciidoctor >=1.5 and <3.x.  However, the current ebuild incorrectly sets the rdepend that constrains the use of >asciidoctor-1.5.  The following patch should fix it.

diff -ruN /usr/portage/dev-ruby/asciidoctor-diagram/asciidoctor-diagram-1.5.16.ebuild asciidoctor-diagram-1.5.16.ebuild 
--- /usr/portage/dev-ruby/asciidoctor-diagram/asciidoctor-diagram-1.5.16.ebuild 2019-04-15 00:09:35.000000000 -0500
+++ asciidoctor-diagram-1.5.16.ebuild   2019-04-17 06:47:15.651124313 -0500
@@ -3,7 +3,7 @@
 
 EAPI=6
 
-USE_RUBY="ruby23 ruby24 ruby25"
+USE_RUBY="ruby24 ruby25 ruby26"
 
 RUBY_FAKEGEM_RECIPE_TEST="rspec3"
 
@@ -23,7 +23,7 @@
 KEYWORDS="~amd64"
 IUSE=""
 
-ruby_add_rdepend "=dev-ruby/asciidoctor-1.5* <dev-ruby/asciidoctor-3"
+ruby_add_rdepend ">=dev-ruby/asciidoctor-1.5 <dev-ruby/asciidoctor-3"
 
 all_ruby_prepare() {
        rm Gemfile || die
Comment 1 Larry the Git Cow gentoo-dev 2019-04-21 06:11:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7c2bb52fc47269b75ab86dc5f7f27c71bf06cd0b

commit 7c2bb52fc47269b75ab86dc5f7f27c71bf06cd0b
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2019-04-21 06:11:08 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2019-04-21 06:11:08 +0000

    dev-ruby/asciidoctor-diagram: fix dependency
    
    Fix asciidoctor dependency to actually include asciidoctor 2.x. Patch by
    Amel Hodzic.
    
    Fixes: https://bugs.gentoo.org/683670
    Signed-off-by: Hans de Graaff <graaff@gentoo.org>
    Package-Manager: Portage-2.3.62, Repoman-2.3.11

 dev-ruby/asciidoctor-diagram/asciidoctor-diagram-1.5.16.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)