Bug 683008 – x11-term/rxvt-unicode musl support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jory A. Pratt 2019-04-10 07:22:59 UTC]

Created attachment 572366 [details, diff]
disable utmp/wtmp/lastlog on musl

Please apply the patch so musl user do not have to depend on overlay to build.

[Comment 1 Jeroen Roovers (RETIRED) 2019-04-10 12:56:22 UTC]

Comment on attachment 572366 [details, diff]
disable utmp/wtmp/lastlog on musl

>From 9667ae51f89b087e03c7294f5d716d5b020a9d00 Mon Sep 17 00:00:00 2001
>From: Jory Pratt <[e-mail]>
>Date: Wed, 10 Apr 2019 02:18:48 -0500
>Subject: [PATCH] x11-term/rxvt-unicode: Fix musl support
>
>---
> x11-terms/rxvt-unicode/rxvt-unicode-9.22-r1.ebuild | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/x11-terms/rxvt-unicode/rxvt-unicode-9.22-r1.ebuild b/x11-terms/rxvt-unicode/rxvt-unicode-9.22-r1.ebuild
>index 45679e5cf..c12dec741 100644
>--- a/x11-terms/rxvt-unicode/rxvt-unicode-9.22-r1.ebuild
>+++ b/x11-terms/rxvt-unicode/rxvt-unicode-9.22-r1.ebuild
>@@ -61,7 +61,10 @@ src_configure() {
> 		$(use_enable pixbuf) \
> 		$(use_enable startup-notification) \
> 		$(use_enable unicode3) \
>-		$(use_enable xft)
>+		$(use_enable xft) \
>+		$(use_enable !elibc_musl utmp) \
>+		$(use_enable !elibc_musl wtmp) \
>+		$(use_enable !elibc_musl lastlog)
> }

To me this looks like we should add IUSE="utmp wtmp" instead and then mask those in musl profiles.

[Comment 2 Larry the Git Cow 2019-04-10 13:49:22 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=76344fabfd15a262985f3705851b374c60187717

commit 76344fabfd15a262985f3705851b374c60187717
Author:     Jeroen Roovers <[e-mail]>
AuthorDate: 2019-04-10 13:48:49 +0000
Commit:     Jeroen Roovers <[e-mail]>
CommitDate: 2019-04-10 13:49:18 +0000

    x11-terms/rxvt-unicode: Add IUSE="utmp wtmp"
    
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Bug: https://bugs.gentoo.org/683008
    Signed-off-by: Jeroen Roovers <[e-mail]>

 x11-terms/rxvt-unicode/metadata.xml                | 50 ++++++------
 x11-terms/rxvt-unicode/rxvt-unicode-9.22-r2.ebuild | 89 ++++++++++++++++++++++
 x11-terms/rxvt-unicode/rxvt-unicode-9999.ebuild    | 42 +++++-----
 3 files changed, 135 insertions(+), 46 deletions(-)

[Comment 3 Jory A. Pratt 2019-04-10 17:08:07 UTC]

I went ahead and masked utmp/wtmp useflags for musl so we can close this now.