Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 682012 - dev-python/enum34 is incompatible with python 3.6+ and pypy3 7.1+
Summary: dev-python/enum34 is incompatible with python 3.6+ and pypy3 7.1+
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-29 12:02 UTC by penguinolog
Modified: 2019-03-30 17:43 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description penguinolog 2019-03-29 12:02:14 UTC
Currently enum3.4 is allowed to install (and in package dependencies) for pypy3, but starting from pypy3 7.1 it should not be installed anymore.
Installation is impossible and manual install will break enum usage.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-03-29 13:13:06 UTC
Yeah, sorry about that.  PyPy3 updates are kinda rough at the moment.  I'm going to give it a few more days, then remove the old version and start updating packages.
Comment 2 Dennis Schridde 2019-03-30 14:04:31 UTC
What would be the correct fix for this?  PYTHON_COMPAT is not Python version-specific for pypy3 -- I do not see how the ebuild could patched to prevent enum34 from being build using pypy3, if >=pypy3-7.1 is being used.
Comment 3 Virgil Dupras (RETIRED) gentoo-dev 2019-03-30 14:24:08 UTC
hasn't enum34 been useless in pypy3 for a while now? enum is a builtin in pypy3 6.0. I think we can just drop pypy3 from the virtual's PYTHON_COMPAT.
Comment 4 Virgil Dupras (RETIRED) gentoo-dev 2019-03-30 14:25:10 UTC
(hum, I meant from its python_gen_cond_dep, sorry)
Comment 5 Dennis Schridde 2019-03-30 16:50:36 UTC
(In reply to Virgil Dupras from comment #3)
> hasn't enum34 been useless in pypy3 for a while now? enum is a builtin in
> pypy3 6.0. I think we can just drop pypy3 from the virtual's PYTHON_COMPAT.

(In reply to Virgil Dupras from comment #4)
> (hum, I meant from its python_gen_cond_dep, sorry)

That would remove the dependency on dev-python/enum34 for most packages, but there are still several packages which do not depend on virtual/python-enum34, but on dev-python/enum34 directly.

For example (installed on my system):
dev-python/flake8-3.6.0:0/0::gentoo
dev-python/cryptography-2.5:0/0::gentoo

But also others, which I found using `rg dev-python/enum34` in the Gentoo repository.
Comment 6 Larry the Git Cow gentoo-dev 2019-03-30 17:43:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7edc8d1b84f526592b229b89bffcbe4b0c5c1cca

commit 7edc8d1b84f526592b229b89bffcbe4b0c5c1cca
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-03-30 14:44:43 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-03-30 17:43:14 +0000

    dev-python/enum34: Remove pypy3
    
    Closes: https://bugs.gentoo.org/682012
    Closes: https://github.com/gentoo/gentoo/pull/11545
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/enum34/{enum34-1.1.6.ebuild => enum34-1.1.6-r1.ebuild} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d9eb4d33f7f3e34f4a42396684ab1e2e9a23a57

commit 0d9eb4d33f7f3e34f4a42396684ab1e2e9a23a57
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-03-30 14:43:27 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-03-30 17:43:00 +0000

    virtual/python-enum34: pypy3 no longer requires enum34
    
    Bug: https://bugs.gentoo.org/682012
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../{python-enum34-1.ebuild => python-enum34-2.ebuild}              | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)