681876 – dev-python/pygit2-0.27.4 should conditionally depend on dev-python/pytest

Bug 681876 - dev-python/pygit2-0.27.4 should conditionally depend on dev-python/pytest

Summary: dev-python/pygit2-0.27.4 should conditionally depend on dev-python/pytest

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Michał Górny

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2019-03-27 19:35 UTC by Chris Mayo
Modified:	2019-03-28 13:49 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Mayo 2019-03-27 19:35:54 UTC

ebuild has:

DEPEND="${RDEPEND}
	dev-python/pytest[${PYTHON_USEDEP}]"

To me it looks like pytest is only needed for tests:

pygit2-0.27.4 $ grep -rn pytest | grep -v test/
CHANGELOG.rst:45:- Move to pytest, drop support for Python 3.3 and cffi 0.x
tox.ini:5:deps = pytest
tox.ini:6:commands = pytest --junitxml=junit-{envname}.xml {posargs}
docs/development.rst:18:    $ pytest test

Comment 1 Michał Górny archtester

2019-03-28 13:48:43 UTC

My mistake, sorry.

Comment 2 Larry the Git Cow gentoo-dev

2019-03-28 13:49:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b051a290fe10bcb4435d9dbd23e3fa24de6217c2

commit b051a290fe10bcb4435d9dbd23e3fa24de6217c2
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-03-28 13:48:46 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-03-28 13:49:48 +0000

    dev-python/pygit2: pytest is needed for tests only
    
    Closes: https://bugs.gentoo.org/681876
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/pygit2/pygit2-0.27.4.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)