Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 681744 - dev-python/cftime-1.0.3.4 - Time-handling functionality from netcdf4-python
Summary: dev-python/cftime-1.0.3.4 - Time-handling functionality from netcdf4-python
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL: https://github.com/Unidata/cftime
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks: 612112
  Show dependency tree
 
Reported: 2019-03-25 17:26 UTC by Juan Hernandez-Diaz
Modified: 2020-12-28 16:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
cftime-1.0.3.4.ebuild (cftime-1.0.3.4.ebuild,738 bytes, text/plain)
2019-03-25 17:27 UTC, Juan Hernandez-Diaz
Details
cftime-1.0.3.4.ebuild (cftime-1.0.3.4.ebuild,548 bytes, text/plain)
2019-03-25 19:30 UTC, Juan Hernandez-Diaz
Details
ebuild for version 1.1.3 (cftime-1.1.3.ebuild,696 bytes, text/plain)
2020-05-22 12:08 UTC, Erik Quaeghebeur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Juan Hernandez-Diaz 2019-03-25 17:26:46 UTC
Hi!

Please find attached cftime-1.0.3.4.ebuild so that it will
compile against python-2.7 and python-3.6

cftime is the Time-handling module from netcdf4-python. This module is developed and maintained by UNIDATA of UCAR (https://www.unidata.ucar.edu/). This package is necessary for the compilation and use of the NetCDF4-C python interface

I suggest dev-python/cftime, this ebuild is a mandatory dependency of the NetCDF4 package in its version 1.5.0.

J.C Hernandez-Diaz
Comment 1 Juan Hernandez-Diaz 2019-03-25 17:27:30 UTC
Created attachment 570726 [details]
cftime-1.0.3.4.ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-25 17:43:27 UTC
Comment on attachment 570726 [details]
cftime-1.0.3.4.ebuild

># Copyright 1999-2017 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
>
>
># Copyright 1999-2019 Gentoo Authors
># Distributed under the terms of the GNU General Public License v2

Two headers?

>EAPI=7
>
>PYTHON_COMPAT=( python2_7 python3_6 )
>inherit distutils-r1
>
>DESCRIPTION="Time-handling functionality from netcdf4-python"
>HOMEPAGE="https://github.com/Unidata/cftime"
>SRC_URI="https://files.pythonhosted.org/packages/7a/83/a61141ec141ceb0617468e04cc163dbdb9007b958191043618d1dc950b8f/${P}.tar.gz"

That is not a nice URL. Could a github link improve on that?

>
>LICENSE="MIT"
>SLOT="0"
>KEYWORDS="~amd64"
>IUSE=""

No need to set an empty IUSE.

>RDEPEND=">=dev-python/numpy-1.8.2[${PYTHON_USEDEP}]
>	 >=dev-python/cython-0.25.2[${PYTHON_USEDEP}]
>        "

That is weird whitespace. A couple of contradictory whitespace conventions are in use already, so I shouldn't think adding another one will hurt.


>DEPEND="${RDEPEND}
>dev-python/setuptools[${PYTHON_USEDEP}]"

That appears to follow yet another whitespace convention. Bash will not mind though it does help to stick to a single convention.
Comment 3 Juan Hernandez-Diaz 2019-03-25 19:29:51 UTC
(In reply to Jeroen Roovers from comment #2)

Jeroen

I have modified my ebuild, according to the observations you make.
Comment 4 Juan Hernandez-Diaz 2019-03-25 19:30:26 UTC
Created attachment 570808 [details]
cftime-1.0.3.4.ebuild
Comment 5 Erik Quaeghebeur 2019-07-16 08:35:33 UTC
Shouldn't the license be GPL-3?

See https://github.com/Unidata/cftime/blob/v1.0.3.4rel/COPYING lines 44-46.
Comment 6 Juan Hernandez-Diaz 2019-07-16 19:29:21 UTC
(In reply to Erik Quaeghebeur from comment #5)
> Shouldn't the license be GPL-3?
> 
> See https://github.com/Unidata/cftime/blob/v1.0.3.4rel/COPYING lines 44-46.

Erik

The licenses confuse me a little. To define the license I referred to the discussions on the subject in the forum of the project on GitHub.

Being strict, the project is defined as OSI APROVED, and in other packages of the same developer they use the MIT license.
Comment 7 Erik Quaeghebeur 2020-05-22 12:08:56 UTC
Created attachment 640882 [details]
ebuild for version 1.1.3

The current most recent version is 1.1.3. I've updated the ebuild. It installs and seems to work here. I've also removed Python 2.7 support given that it's deprecated, although the package still supports Python 2.7.

Perhaps the bug title should be updated to reflect the new version.
Comment 8 Larry the Git Cow gentoo-dev 2020-12-28 16:11:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e674ac4eb4457ebbf32eb5824f7745487903a3f9

commit e674ac4eb4457ebbf32eb5824f7745487903a3f9
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2020-12-28 16:10:48 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-12-28 16:10:48 +0000

    dev-python/cftime: Time-handling functionality from netcdf4-python
    
    Closes: https://bugs.gentoo.org/681744
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-python/cftime/Manifest            |  1 +
 dev-python/cftime/cftime-1.3.0.ebuild | 29 +++++++++++++++++++++++++++++
 dev-python/cftime/metadata.xml        | 12 ++++++++++++
 3 files changed, 42 insertions(+)