Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 681056 - app-backup/btrbk - add USE=doc
Summary: app-backup/btrbk - add USE=doc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-20 17:41 UTC by Forza
Modified: 2019-03-25 15:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Depend on asciidoctor, add USE=+doc (btrbk_depend_asciidoctor_and_add_use_doc.patch,1.08 KB, patch)
2019-03-25 13:55 UTC, Axel Burri
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Forza 2019-03-20 17:41:40 UTC
It would be useful to add "doc" USE-flag so that docs can be omitted. 

Currently Btrbk uses app-text/asciidocto make man-pages. Asciidoc uses Python-2.7, so this is a blocker for the deprecation of python-2.7. 

Also, dev-ruby/asciidoctor could be used instead of app-text/asciidoc to support Python-3.
Comment 1 Axel Burri 2019-03-25 13:55:00 UTC
Created attachment 570714 [details, diff]
Depend on asciidoctor, add USE=+doc

This patch adds "USE=+doc", allowing to build btrbk without the docs, removing the need of installing "asciidoc" or "asciidoctor" build-time dependencies.

Also change dependency to "dev-ruby/asciidoctor", which is preferred as "app-text/asciidoc" is discontinued and depends on python-2.7.

This patch should also be applied to "app-backup/btrbk-9999.ebuild".

Note that btrbk is still able to compile the docs using asciidoc+xmlto, this would also work:

    DEPEND="doc? ( || ( >=dev-ruby/asciidoctor-1.5.7 ( >=app-text/asciidoc-8.6.0 app-text/xmlto ) ) )"

Note that btrbk is a single perl script, and does not require any special installation procedures or libraries. There is no need to run any build target if you don't want to build the man pages (see doc/Makefile).
Comment 2 Craig Andrews gentoo-dev 2019-03-25 15:25:50 UTC
Thank you!
Comment 3 Larry the Git Cow gentoo-dev 2019-03-25 15:26:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c018f15ba322ef3d927b011bdfa72652ac30a5a

commit 2c018f15ba322ef3d927b011bdfa72652ac30a5a
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2019-03-25 15:25:53 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-03-25 15:26:39 +0000

    app-backup/btrbk: add USE=doc
    
    Closes: https://bugs.gentoo.org/681056
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 app-backup/btrbk/btrbk-0.27.1-r1.ebuild | 72 +++++++++++++++++++++++++++++++++
 app-backup/btrbk/btrbk-9999.ebuild      | 14 ++++---
 2 files changed, 81 insertions(+), 5 deletions(-)