Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 681054 - games-rpg/arx-libertatis-1.1.2-r2 : Unknown CMake command check_include_files .
Summary: games-rpg/arx-libertatis-1.1.2-r2 : Unknown CMake command check_include_files .
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2020-03-18
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2019-03-20 17:41 UTC by Toralf Förster
Modified: 2020-03-19 07:15 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.36 KB, text/plain)
2019-03-20 17:41 UTC, Toralf Förster
Details
CMakeError.log (CMakeError.log,28.45 KB, text/plain)
2019-03-20 17:41 UTC, Toralf Förster
Details
CMakeOutput.log (CMakeOutput.log,75.95 KB, text/plain)
2019-03-20 17:41 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,103.97 KB, text/plain)
2019-03-20 17:41 UTC, Toralf Förster
Details
environment (environment,118.30 KB, text/plain)
2019-03-20 17:41 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,13.08 KB, application/x-bzip)
2019-03-20 17:41 UTC, Toralf Förster
Details
games-rpg:arx-libertatis-1.1.2-r2:20190320-150327.log (games-rpg:arx-libertatis-1.1.2-r2:20190320-150327.log,6.71 KB, text/plain)
2019-03-20 17:41 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,7.84 KB, application/x-bzip)
2019-03-20 17:41 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,28.67 KB, application/x-bzip)
2019-03-20 17:41 UTC, Toralf Förster
Details
Fix needed for cmake 1.4+ (arx-libertatis-1.1.2-cmake-1.4.patch,726 bytes, patch)
2019-08-18 11:34 UTC, Jesper Saxtorph
Details | Diff
New ebuild using latest upstream release (arx-libertatis-1.1.2_p2.ebuild,2.27 KB, text/plain)
2020-02-24 12:52 UTC, Jesper Saxtorph
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-03-20 17:41:28 UTC
-- Looking for clock_gettime - not found
CMake Error at CMakeLists.txt:453 (check_include_files):
  Unknown CMake command "check_include_files".


-- Configuring incomplete, errors occurred!

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1-developer_libressl-test_20190317-122112

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-8.3.0 *

Available Python interpreters, in order of preference:
  [1]   python3.6
  [2]   python2.7 (fallback)

Available Rust versions:
  [1]   rust-1.32.0 *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.10.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

emerge -qpvO games-rpg/arx-libertatis
[ebuild  N    ] games-rpg/arx-libertatis-1.1.2-r2  USE="unity-build -c++0x -crash-reporter -debug -static -tools"
Comment 1 Toralf Förster gentoo-dev 2019-03-20 17:41:31 UTC
Created attachment 570022 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2019-03-20 17:41:33 UTC
Created attachment 570024 [details]
CMakeError.log
Comment 3 Toralf Förster gentoo-dev 2019-03-20 17:41:36 UTC
Created attachment 570026 [details]
CMakeOutput.log
Comment 4 Toralf Förster gentoo-dev 2019-03-20 17:41:39 UTC
Created attachment 570028 [details]
emerge-history.txt
Comment 5 Toralf Förster gentoo-dev 2019-03-20 17:41:42 UTC
Created attachment 570030 [details]
environment
Comment 6 Toralf Förster gentoo-dev 2019-03-20 17:41:45 UTC
Created attachment 570032 [details]
etc.portage.tbz2
Comment 7 Toralf Förster gentoo-dev 2019-03-20 17:41:47 UTC
Created attachment 570034 [details]
games-rpg:arx-libertatis-1.1.2-r2:20190320-150327.log
Comment 8 Toralf Förster gentoo-dev 2019-03-20 17:41:50 UTC
Created attachment 570036 [details]
logs.tbz2
Comment 9 Toralf Förster gentoo-dev 2019-03-20 17:41:53 UTC
Created attachment 570038 [details]
temp.tbz2
Comment 10 Jesper Saxtorph 2019-08-18 11:34:22 UTC
Created attachment 587356 [details, diff]
Fix needed for cmake 1.4+

This patch fixes the Arx Libertatis CMakeLists.txt to work with cmake 1.4.
The problem is that the set command act different on quotes now, so it end up with:
/usr/bin/x86_64-pc-linux-gnu-gcc -D_POSIX_C_SOURCE="200809L -D_XOPEN_SOURCE=600"
Note the quotes.
The simple solution was to remove the quotes.
Comment 11 Larry the Git Cow gentoo-dev 2020-02-17 08:17:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a3ed37befd55bb9e333b574d2e812a8eff88364

commit 2a3ed37befd55bb9e333b574d2e812a8eff88364
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-02-17 07:54:49 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-02-17 08:17:26 +0000

    package.mask: Last rite games-rpg/arx-libertatis
    
    Bug: https://bugs.gentoo.org/681054
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 12 Jesper Saxtorph 2020-02-17 12:37:30 UTC
I just had a look at this bug again because of the pmask.
I can see I have for some unknown reason messed up with the version number in my old comment/patch name.
The patch was of course not for cmake 1.4+ but for cmake 3.14+
And the patch is working perfectly for me. I have just tried to recompile and running the game with no problems.
So in my opinion there is no reason to remove it. Just rename my old patch and add it.
However if you want to remove it because of lack of interest, I will just move it to my local overlay.
Comment 13 Daniel Scharrer 2020-02-23 14:49:52 UTC
https://github.com/gentoo/gentoo/pull/13983 ¯\_(ツ)_/¯
Comment 14 Jesper Saxtorph 2020-02-24 12:52:20 UTC
Created attachment 615446 [details]
New ebuild using latest upstream release

From pull request link given by Daniel I can see that a fix was provided in the form of a patch on the ebuild side. There was a question of why not using a new upstream release and no one ever answered that.

I can see that upstream seems active, but have only release small patch releases for many years. However, the latest patch release is exactly the what Danial made available through his pull request.

So I guess the correct way would be to add a new ebuild pulling the newest upstream release. I have made such an ebuild. Three things are changed:
1) Pull newest upstream release (which needed some change in name/version handling).
2) Remove cmake-3.5.patch as it is part of new upstream.
3) Removed c++0x use flag as it do not really make sense these days (I have not looked into the exact details of what it does).

As a side node, I have not installed the games-rpg/arx-fatalis-data or games-rpg/arx-fatalis-demo which is refered by this ebuild and are now also pmasked. I guess they are pmasked because they depend on this ebuild, so if this ebuild is accepted, the other two should probably be reconsidered.