Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 680844 - sys-fs/squashfs-tools-4.3_p11: memory leak while creating squashfs file
Summary: sys-fs/squashfs-tools-4.3_p11: memory leak while creating squashfs file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo LiveCD Package Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-18 10:54 UTC by Pacho Ramos
Modified: 2019-04-15 14:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2019-03-18 10:54:44 UTC
I think it's the same as:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921146
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923711

But it doesn't depend on using -mem option (I never use it), it is a general memory leak that, in my case, ends up with OOMKiller needing to kill it

I am trying to find the offending patch causing this regression over _p7
Comment 2 Pacho Ramos gentoo-dev 2019-03-18 14:38:21 UTC
Dropping 0016-remove-frag_deflator_thread.patch and 0017-add-zstd-support.patch stops the memory leak
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-18 15:13:09 UTC
Weird. Is it defaulting to zstd?
Comment 4 Pacho Ramos gentoo-dev 2019-03-18 16:27:03 UTC
The real culprit is only 0016-remove-frag_deflator_thread.patch (just checked now)

I experience this with XZ compression
Comment 5 Larry the Git Cow gentoo-dev 2019-03-18 16:52:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=403e623c705521b9e6ae590f38a6d9599b4a23aa

commit 403e623c705521b9e6ae590f38a6d9599b4a23aa
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-03-18 16:52:21 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-03-18 16:52:45 +0000

    sys-fs/squashfs-tools: Drop 0016-remove-frag_deflator_thread.patch
    
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Bug: https://bugs.gentoo.org/680844
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 .../squashfs-tools-4.3_p11-r1.ebuild               | 85 ++++++++++++++++++++++
 1 file changed, 85 insertions(+)
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-18 16:53:35 UTC
0016-remove-frag_deflator_thread.patch purportedly fixing something to do with LZO. Not entirely sure. Could you try -r1?
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2019-04-10 11:44:10 UTC
commit 62080301b42cc144c9e66e67bcbcc7785fec6322 (HEAD -> master, origin/master, origin/HEAD)
Author: Jeroen Roovers <jer@gentoo.org>
Date:   Wed Apr 10 13:40:20 2019 +0200

    sys-fs/squashfs-tools: Version 4.3_p12

    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2019-04-10 11:48:00 UTC
Hm, maybe it isn't fixed yet? I just read the comments on the upstream tracker and it looks like Debian has patched the patch.
Comment 9 Pacho Ramos gentoo-dev 2019-04-15 14:35:14 UTC
it seems it works ok now :)