Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 680528 - media-sound/teamspeak-client-3.2.3 should RDEPEND on =dev-libs/openssl-1.0.2r-r200
Summary: media-sound/teamspeak-client-3.2.3 should RDEPEND on =dev-libs/openssl-1.0.2r...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-03-16 01:19 UTC by lupus
Modified: 2019-04-30 16:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lupus 2019-03-16 01:19:09 UTC
Since net-misc/nextcloud-client was upgraded to RDPEND >=dev-libs/openssl-1.1.0:0=, I was forced to upgrade my system openssl.
I ended up downloading genthree's teamspeak3-client overlay ebuild, after testing his useflag, -system-openssl, I also edited the ebuild to not require =dev-libs/openssl-1.0*:* for system-openssl.
To my surprise it just works, I'm running teamspeak3-client with dev-libs/openssl-1.1.0j-r1, without any problems. I'm wondering why this RDEPEND was put in place, it seems unnecessary now atleast.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-16 10:55:01 UTC
~/portage/media-sound/teamspeak-client-3.2.3-r1/work $
scanelf -Rn . | grep libcrypto
ET_DYN libdl.so.2,libz.so.1,libc.so.6 ./libcrypto.so.1.0.0
ET_DYN libcrypto.so.1.0.0,libc.so.6 ./libssl.so.1.0.0


As far as I can tell the current ebuilds get this right:

   teamspeak-client-3.2.3.ebuild : RDEPEND -=- <dev-libs/openssl-1.1:0
teamspeak-client-3.2.3-r1.ebuild : RDEPEND -=- =dev-libs/openssl-1.0*:*

That should pull in =dev-libs/openssl-1.0.2r-r200 which is a library-only package intended for use with closed source executables like teamspeak-client.
Comment 2 Conrad Kostecki gentoo-dev 2019-03-30 13:19:29 UTC
Hi!
I've digged into it. This seems to be a mistake by me.
The dependency for dev-libs/openssl for 1.0.2 isn't needed at all.

It would be only needed, when I would use all shipped libs, which I don't do, as I use the system ones installed. And since dev-qt/qt* can be compiled with openssl-1.1, this can be used by teamspeak.

I will push a new PR, which will change it pack to dev-libs/openssl:0, since 1.1 can be used in this case.

Conrad
Comment 3 Larry the Git Cow gentoo-dev 2019-04-30 16:49:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f9cad978471870aa00c28d66029570e0b3f3e5d9

commit f9cad978471870aa00c28d66029570e0b3f3e5d9
Author:     Denis Lisov <dennis.lissov@gmail.com>
AuthorDate: 2019-04-09 13:07:53 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-04-30 16:49:36 +0000

    media-sound/teamspeak-client: depend on openssl:0
    
    According to the linked bug, this is a mistake. teamspeak-client
    runs with openssl-1.1.0j-r1 successfully.
    
    Closes: https://bugs.gentoo.org/680528
    Signed-off-by: Denis Lisov <dennis.lissov@gmail.com>
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 media-sound/teamspeak-client/teamspeak-client-3.2.3-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)