Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 680306 - net-misc/youtube-dl should depend on dev-python/pycrypto(dome?)
Summary: net-misc/youtube-dl should depend on dev-python/pycrypto(dome?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
: 715482 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-03-14 10:20 UTC by Jens Rex
Modified: 2020-03-31 05:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Rex 2019-03-14 10:20:34 UTC 
Youtube-dl needs either pycrypto, or ffmpeg built with SSL support, to download from https sources.

pycrypto is the much cleaner solution.

Ref.: https://github.com/ytdl-org/youtube-dl/blob/6db03a29d139aa7594b24117b912b589c7683a96/youtube_dl/downloader/hls.py#L66
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-14 10:56:04 UTC 
I guess you mean this:

/usr/lib64/python2.7/site-packages/youtube_dl/downloader/hls.py:                self.report_error('pycrypto not found. Please install it.')
/usr/lib64/python3.6/site-packages/youtube_dl/downloader/hls.py:                self.report_error('pycrypto not found. Please install it.')

So then you install pycrypto, I guess. I could add that to the elog messages, I guess. Or do you think HTTPS is so important that it warrants the additional hard dependency?
Comment 2 Jens Rex 2019-03-14 11:00:09 UTC 
(In reply to Jeroen Roovers from comment #1)

> Or do you think HTTPS is so important that it warrants
> the additional hard dependency?

Considering that nearly everything is HTTPS these days, there's certainly a strong case for including it by default, in my opinion.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-14 12:43:48 UTC 
Fair point.
Comment 4 Larry the Git Cow gentoo-dev 2019-03-14 12:59:37 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=785d68710367264f33e8b2bdd68934f61a7c9d5d

commit 785d68710367264f33e8b2bdd68934f61a7c9d5d
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-03-14 12:58:51 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-03-14 12:59:32 +0000

    net-misc/youtube-dl: RDEPEND on dev-python/pycryptodome
    
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Fixes: https://bugs.gentoo.org/680306
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 ...be-dl-2019.03.09.ebuild => youtube-dl-2019.03.09-r1.ebuild} | 10 +++++++---
 net-misc/youtube-dl/youtube-dl-99999999.ebuild                 | 10 +++++++---
 2 files changed, 14 insertions(+), 6 deletions(-)
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-14 13:12:56 UTC 
Wouldn't it actually be enough to depend on dev-lang/python[ssl]?
Comment 6 Jens Rex 2019-03-14 13:40:06 UTC 
It looks like pycryptodome is a newer replacement for pycrypto, and I just confirmed it works as intended with youtube-dl. Sorry, I'm not terribly familiar with Python.

(In reply to Jeroen Roovers from comment #5)
> Wouldn't it actually be enough to depend on dev-lang/python[ssl]?

My Python is installed with +ssl, and I still had the problem described in OP, so it seems it's not enough.
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2019-03-14 13:49:52 UTC 
OK, that settles it then. Thanks for testing.
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2020-03-31 05:42:33 UTC 
*** Bug 715482 has been marked as a duplicate of this bug. ***