Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 680084 - dev-util/sysdig-0.24.2 - .../work/sysdig-0.24.2/driver/ppm_events.c:89:48: error: macro "access_ok" passed 3 arguments, but takes just 2
Summary: dev-util/sysdig-0.24.2 - .../work/sysdig-0.24.2/driver/ppm_events.c:89:48: er...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-11 20:32 UTC by Pavel Volkov
Modified: 2019-03-11 21:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,482.24 KB, text/plain)
2019-03-11 20:32 UTC, Pavel Volkov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2019-03-11 20:32:44 UTC
Created attachment 568734 [details]
build.log

I have this compile error with sysdig 0.24.2 and kernel 5.0.0:

  CC [M]  /var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_cputime.o
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c: In function ‘ppm_copy_from_user’:
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:89:48: error: macro "access_ok" passed 3 arguments, but takes just 2
  if (likely(ppm_access_ok(VERIFY_READ, from, n)))
                                                ^
In file included from ./include/linux/export.h:45,
                 from ./include/linux/linkage.h:7,
                 from ./arch/x86/include/asm/cache.h:5,
                 from ./include/linux/cache.h:6,
                 from ./include/linux/time.h:5,
                 from ./include/linux/compat.h:10,
                 from /var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:12:
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:49:23: error: ‘access_ok’ undeclared (first use in this function); did you mean ‘access_flags’?
 #define ppm_access_ok access_ok
                       ^~~~~~~~~
./include/linux/compiler.h:76:40: note: in definition of macro ‘likely’
 # define likely(x) __builtin_expect(!!(x), 1)
                                        ^
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:89:13: note: in expansion of macro ‘ppm_access_ok’
  if (likely(ppm_access_ok(VERIFY_READ, from, n)))
             ^~~~~~~~~~~~~
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:49:23: note: each undeclared identifier is reported only once for each function it appears in
 #define ppm_access_ok access_ok
                       ^~~~~~~~~
./include/linux/compiler.h:76:40: note: in definition of macro ‘likely’
 # define likely(x) __builtin_expect(!!(x), 1)
                                        ^
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:89:13: note: in expansion of macro ‘ppm_access_ok’
  if (likely(ppm_access_ok(VERIFY_READ, from, n)))
             ^~~~~~~~~~~~~
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c: In function ‘ppm_strncpy_from_user’:
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:120:54: error: macro "access_ok" passed 3 arguments, but takes just 2
   if (!ppm_access_ok(VERIFY_READ, from, bytes_to_read)) {
                                                      ^
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:49:23: error: ‘access_ok’ undeclared (first use in this function); did you mean ‘access_flags’?
 #define ppm_access_ok access_ok
                       ^~~~~~~~~
/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.c:120:8: note: in expansion of macro ‘ppm_access_ok’
   if (!ppm_access_ok(VERIFY_READ, from, bytes_to_read)) {
        ^~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:276: /var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver/ppm_events.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1553: _module_/var/tmp/portage/dev-util/sysdig-0.24.2/work/sysdig-0.24.2/driver] Error 2
make[1]: Leaving directory '/usr/src/linux-5.0.0-gentoo'
make: *** [Makefile:16: all] Error 2



Portage 2.3.62 (python 3.6.8-final-0, default/linux/amd64/17.0/desktop/plasma/systemd, gcc-8.3.0, glibc-2.28-r5, 5.0.0-gentoomelf x86_64)
=================================================================
System uname: Linux-5.0.0-gentoomelf-x86_64-Intel-R-_Core-TM-_i5-2400_CPU_@_3.10GHz-with-gentoo-2.6
KiB Mem:    16370260 total,   6314964 free
KiB Swap:   17825788 total,  17825788 free
Timestamp of repository gentoo: Mon, 11 Mar 2019 19:15:01 +0000
Head commit of repository gentoo: 2afcd410565b2f295777db7b9abed7e294f08169
sh bash 5.0_p2
ld GNU ld (Gentoo 2.32 p1) 2.32.0
app-shells/bash:          5.0_p2::gentoo
dev-lang/perl:            5.28.0::gentoo
dev-lang/python:          2.7.16::gentoo, 3.6.8::gentoo, 3.7.2::gentoo
dev-util/cmake:           3.13.4::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.15::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.32::gentoo
sys-devel/gcc:            8.3.0::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.0-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.28-r5::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync2.ru.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: no
    sync-rsync-extra-opts: -4
    sync-rsync-verify-max-age: 24

chaoslab
    location: /var/lib/layman/chaoslab
    sync-type: laymansync
    sync-uri: https://gitlab.com/chaoslab/chaoslab-overlay.git
    masters: gentoo
    priority: 50

libressl
    location: /var/lib/layman/libressl
    sync-type: laymansync
    sync-uri: https://anongit.gentoo.org/git/repo/proj/libressl.git
    masters: gentoo
    priority: 50

mva
    location: /var/lib/layman/mva
    sync-type: laymansync
    sync-uri: https://github.com/msva/mva-overlay
    masters: gentoo
    priority: 50

rion
    location: /var/lib/layman/rion
    sync-type: laymansync
    sync-uri: https://github.com/rion-overlay/rion-overlay.git
    masters: gentoo
    priority: 50

custom
    location: /usr/local/portage
    masters: gentoo
    priority: 70

Installed sets: @development, @fonts, @kdeapps, @python-extra
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE freedist linux-firmware no-source-code MPEG-4 unRAR CC-BY-NC-ND-3.0 intel-ucode Samsung-EULA bluez-firmware BitstreamCyberbit MSttfEULA grass-ipafonts free-noncomm bh-luxi"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -mtune=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/ibus/component/simple.xml /var/lib/i2pd/certificates"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/openvpn/update-systemd-resolved /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native -mtune=native"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --quiet-build"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.bloodhost.ru/ http://mirror.yandex.ru/gentoo-distfiles/ http://mirror.leaseweb.com/gentoo/"
INSTALL_MASK="/etc/init.d/ /etc/xinetd.d/ /etc/hosts /etc/networks"
LANG="ru_RU.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_GB ru ja"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="-4"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 anthy berkdb bluetooth branding btrfs bzip2 cacert cairo cdda cdr cjk cli crypt cryptsetup cups cxx dbus declarative djvu dri dts dvd dvdr egl emboss encode exif fam ffmpeg flac fortran gdbm gif git glamor gpg gpm gstreamer gtk ibus iconv icu idn ipv6 jpeg kde kipi kwallet lcms libnotify libressl libtirpc lm_sensors mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp opus pam pango pcre pdf phonon plasma png policykit ppds pulseaudio python qml qt5 raw readline samba scanner sdl seccomp spell ssl startup-notification svg systemd tcpd tiff truetype udev udisks unicode upower usb v4l vorbis wayland widgets wxwidgets x264 x265 xattr xcb xcomposite xml xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" CURL_SSL="libressl" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" L10N="en en-GB ru ja" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="X86 AMDGPU" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6 python3_7" RUBY_TARGETS="ruby25" SANE_BACKENDS="genesys" USERLAND="GNU" VIDEO_CARDS="radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-03-11 20:58:46 UTC
https://github.com/draios/sysdig/commit/2c8f0263382bf64800faec5fba5cc3e005d9fb1e looks relevant.  Could you test whether it fixes all the issues for you?
Comment 2 Pavel Volkov 2019-03-11 21:11:53 UTC
Yes, it worked.
Comment 3 Larry the Git Cow gentoo-dev 2019-03-11 21:44:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92f620de9364d333a3a8dcd6f529ac3861c673c7

commit 92f620de9364d333a3a8dcd6f529ac3861c673c7
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-03-11 21:34:41 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-03-11 21:44:23 +0000

    dev-util/sysdig: Backport fix for building with 5.0.0 kernel
    
    Closes: https://bugs.gentoo.org/680084
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 .../sysdig/files/sysdig-0.24.2-kernel-5.0.0.patch  | 34 ++++++++++++++++++++++
 dev-util/sysdig/sysdig-0.24.2.ebuild               |  7 ++++-
 2 files changed, 40 insertions(+), 1 deletion(-)