Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679890 - x11-misc/sddm creates random directories in $HOME for xorg-session.log
Summary: x11-misc/sddm creates random directories in $HOME for xorg-session.log
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: LxQt maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-10 04:28 UTC by David Korth
Modified: 2019-03-31 09:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Korth 2019-03-10 04:28:10 UTC
x11-misc/sddm-0.18.0 is creating a random 2-character directory in my $HOME directory for the xorg-session.log file. The result is something like $HOME/6V/.local/share/sddm/xorg-session.log. The "6V" changes on every login using sddm, though the last character is usually either 'U' or 'V'.

This appears to be caused by a use-after-free issue with a buffer allocated for getpwnam_r().

Upstream has patched this in the develop branch by replacing the manually-managed buffer with a QScopedPointer:
https://github.com/sddm/sddm/commit/047ef56e5cfa757ebfcb03a248edad579564b5f3

Reproducible: Always

Steps to Reproduce:
1. Log in using sddm.
Actual Results:  
$HOME/xx/.local/share/sddm/xorg-session.log is created, where "xx" is two random characters.

Expected Results:  
$HOME/.local/share/sddm/xorg-session.log is created.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2019-03-11 06:42:50 UTC
On the linked issue, upstream is talking about making a release. Let's give them a few days to do this, and if we don't hear anything further we can backport.
Comment 2 Larry the Git Cow gentoo-dev 2019-03-31 09:04:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=400dc109526e36fb9f206a49fedf7e9f87a84d79

commit 400dc109526e36fb9f206a49fedf7e9f87a84d79
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2019-03-31 09:03:22 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2019-03-31 09:03:54 +0000

    x11-misc/sddm: version bump 0.18.1
    
    Closes: https://bugs.gentoo.org/679890
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Michael Palimaka <kensington@gentoo.org>

 x11-misc/sddm/Manifest           |  1 +
 x11-misc/sddm/sddm-0.18.1.ebuild | 96 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 97 insertions(+)