Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679656 - www-client/firefox: --enable-rust-simd breaks with rust 1.33.0
Summary: www-client/firefox: --enable-rust-simd breaks with rust 1.33.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-07 04:32 UTC by Georgy Yakovlev
Modified: 2019-03-27 23:19 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ff rust-1.33.0 simd errors (ff-rust-simd-err.log,59.62 KB, text/x-log)
2019-03-07 04:32 UTC, Georgy Yakovlev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2019-03-07 04:32:30 UTC
Created attachment 568078 [details]
ff rust-1.33.0 simd errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1521249


attached partial build log
Comment 1 Georgy Yakovlev archtester gentoo-dev 2019-03-07 04:42:44 UTC
rust-1.33.0 committed in 
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07d8596964275c4b0d5659c9ac33d50155058429

and masked in 
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6dce5689090c47308a0adb1f4bc17dd12a574c8


feel free to unmask after taking care of firefox
Comment 2 Oleg 2019-03-07 15:16:10 UTC
Could rust-1.33 be unmasked but installed into different slot so firefox could be built with compatible rust version while having latest rust as well?
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-19 19:12:15 UTC
Status update: There is no simple solution. Therefore we tend to skip rust-1.33 release.

(In reply to Oleg from comment #2)
> Could rust-1.33 be unmasked but installed into different slot so firefox
> could be built with compatible rust version while having latest rust as well?
In theory this should be possible. However, rust-1.2x which allows separated cargo makes it complicated (we would have to change dev-utils/cargo to not install /usr/bin/cargo but eselect-rust can only work with _one_ provider file; once we have solved this problem we would have to deal with the problem that version X requires cargo from Y but version Z from W...). So no, as long as we have separated cargo in tree, I don't see us having slotted rust support.
Comment 4 Larry the Git Cow gentoo-dev 2019-03-27 23:19:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f983efbbc6b65e9e53d7a16713ead23348dd50d6

commit f983efbbc6b65e9e53d7a16713ead23348dd50d6
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-03-27 23:13:35 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-03-27 23:17:49 +0000

    package.mask: drop >=rust-1.33 mask
    
    Mask is no longer needed, we added patches to firefox.
    
    Closes: https://bugs.gentoo.org/679656
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 profiles/package.mask | 9 ---------
 1 file changed, 9 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9a4ec65197a6f35305fb393006651aaa6541659

commit d9a4ec65197a6f35305fb393006651aaa6541659
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-03-27 23:10:41 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-03-27 23:17:46 +0000

    www-client/firefox: add rust-1.33 support
    
    Bug: https://bugs.gentoo.org/679656
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/Manifest              | 1 +
 www-client/firefox/firefox-60.6.1.ebuild | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f1462820b95e68cd9fa572f5183fc85587b424b

commit 5f1462820b95e68cd9fa572f5183fc85587b424b
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-03-27 23:09:28 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-03-27 23:17:45 +0000

    www-client/firefox: bump to v66.0.2
    
    - drop 6004_revert-bug1497976_bug1507655.patch which causes build
      problems for some users. [Bug 681548]
    
    - TerminalLoggingHandler patched to allow non-ascii characters. [Bug 666948]
    
    - Add rust-1.33+ support. [Bug 679656]
    
    Bug: https://bugs.gentoo.org/679656
    Closes: https://bugs.gentoo.org/666948
    Closes: https://bugs.gentoo.org/681548
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/Manifest                        | 185 +++++++++++----------
 ...firefox-66.0.1.ebuild => firefox-66.0.2.ebuild} |   2 +-
 2 files changed, 94 insertions(+), 93 deletions(-)