Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679654 - sci-mathematics/octave-5.1.0 version bump
Summary: sci-mathematics/octave-5.1.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Mathematics related packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-07 02:09 UTC by Anton Kochkov
Modified: 2019-08-25 01:12 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
octave-5.1.0.ebuild (octave-5.1.0.ebuild,5.07 KB, text/plain)
2019-04-01 18:37 UTC, Fabio Rossi
Details
octave-5.1.0-pkgbuilddir.patch (octave-5.1.0-pkgbuilddir.patch,1.31 KB, patch)
2019-04-01 18:37 UTC, Fabio Rossi
Details | Diff
octave-5.1.0.ebuild (octave-5.1.0.ebuild,5.04 KB, text/plain)
2019-04-02 09:55 UTC, Fabio Rossi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Kochkov 2019-03-07 02:09:17 UTC
New major release with huge speed improvements, optimization and overall modernization of the toolkit.

http://www.gnu.org/software/octave/news/release/2019/03/01/octave-5.1-released.html

Summary of the changes https://www.gnu.org/software/octave/NEWS-5.1.html

Source are available here http://mirror.us-midwest-1.nexcess.net/gnu/octave/octave-5.1.0.tar.xz
Comment 1 Fabio Rossi 2019-04-01 18:36:50 UTC
I am attaching a working ebuild for octave 5.1.0, there are two changes comparing to the latest version in portage.

1) update of pkgbuilddir.patch
2) removal of -Wl,-z,defs linker flag

In particular, that additional llinker flag has been introduced in a previous commit related to bug #593670 (see also https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=430460192fa2d64c196a18b34d386d4f244f5755).

Starting from version 5.0 it seems that upstream is underlinking by definition all the shared modules which are usually later loaded at run-time by the core part of the program (during the run-time linking phase all undefined symbols discovered when building are then resolved). This behavior causes link time errors with the -Wl,-z,defs flag which are considered harmless. As a reference see also http://savannah.gnu.org/bugs/?53627
Comment 2 Fabio Rossi 2019-04-01 18:37:29 UTC
Created attachment 571520 [details]
octave-5.1.0.ebuild
Comment 3 Fabio Rossi 2019-04-01 18:37:58 UTC
Created attachment 571522 [details, diff]
octave-5.1.0-pkgbuilddir.patch
Comment 4 Helmut Jarausch 2019-04-02 09:01:21 UTC
(In reply to Fabio Rossi from comment #3)
> Created attachment 571522 [details, diff] [details, diff]
> octave-5.1.0-pkgbuilddir.patch

Many many thanks, Fabio!

I had to apply the following patch (in src_prepare)

sed -i -e's/std::ios::streampos/std::streampos/g' liboctave/util/lo-utils.cc

This might be necessary only because I use gcc-8.x
Comment 5 Fabio Rossi 2019-04-02 09:53:44 UTC
(In reply to Helmut Jarausch from comment #4)
> (In reply to Fabio Rossi from comment #3)
> > Created attachment 571522 [details, diff] [details, diff] [details, diff]
> > octave-5.1.0-pkgbuilddir.patch
> 
> Many many thanks, Fabio!
> 
> I had to apply the following patch (in src_prepare)
> 
> sed -i -e's/std::ios::streampos/std::streampos/g' liboctave/util/lo-utils.cc
> 
> This might be necessary only because I use gcc-8.x

I cannot reproduce the problem you describe in bug #675404, I am also using gcc-8 with glibc 2.28-r5. As requested, please add the additional information to the other bug report you opened
Comment 6 Fabio Rossi 2019-04-02 09:55:15 UTC
Created attachment 571568 [details]
octave-5.1.0.ebuild

deleted configure option --without-OSMesa which has been removed upstream
Comment 7 Helmut Jarausch 2019-04-03 08:41:02 UTC
(In reply to Fabio Rossi from comment #5)
> (In reply to Helmut Jarausch from comment #4)
> > (In reply to Fabio Rossi from comment #3)
> > > Created attachment 571522 [details, diff] [details, diff] [details, diff] [details, diff]
> > > octave-5.1.0-pkgbuilddir.patch
> > 
> > Many many thanks, Fabio!
> > 
> > I had to apply the following patch (in src_prepare)
> > 
> > sed -i -e's/std::ios::streampos/std::streampos/g' liboctave/util/lo-utils.cc
> > 
> > This might be necessary only because I use gcc-8.x
> 
> I cannot reproduce the problem you describe in bug #675404, I am also using
> gcc-8 with glibc 2.28-r5. As requested, please add the additional
> information to the other bug report you opened

I've added some information to that bug report.
In short, streampos is now a member of namespace std and not of std::ios any longer. This is flagged as an error only if one uses -std=c++17.
But it is safe to use std::streampos with -std=c++14.
Comment 8 Anton Kochkov 2019-04-16 20:10:36 UTC
(In reply to Fabio Rossi from comment #6)
> Created attachment 571568 [details]
> octave-5.1.0.ebuild
> 
> deleted configure option --without-OSMesa which has been removed upstream

Can you send a PR to https://github.com/gentoo/gentoo please? This should help to get it in the tree faster.
Comment 9 Larry the Git Cow gentoo-dev 2019-08-25 01:12:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28712fe5aac4a7328f54bfc23bab8e0a10343a19

commit 28712fe5aac4a7328f54bfc23bab8e0a10343a19
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2019-08-25 01:10:13 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2019-08-25 01:12:08 +0000

    sci-mathematics/octave: Bump to 5.1.0.
    
      Adopted to ${PN}-5.1.0-pkgbuilddir.patch with minor changes.
    
      Removed --without-OSMesa as the option is no longer available.
    
      Removed --Wl,-z defs, because upstream designed the related objects
      as loadable plugins.
    
    Reference: http://savannah.gnu.org/bugs/?53627
    Suggested-By: Fabio Rossi
    
    Bug: https://bugs.gentoo.org/593670
    Closes: https://bugs.gentoo.org/661048
    Closes: https://bugs.gentoo.org/679654
    
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 sci-mathematics/octave/Manifest                    |   1 +
 .../octave/files/octave-5.1.0-pkgbuilddir.patch    |  43 +++++
 sci-mathematics/octave/octave-5.1.0.ebuild         | 192 +++++++++++++++++++++
 3 files changed, 236 insertions(+)