Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679498 - app-text/djvu-3.5.27: Icon cache not updated
Summary: app-text/djvu-3.5.27: Icon cache not updated
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: TeX project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-05 08:53 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-11-12 07:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-03-05 08:53:27 UTC
* QA Notice: new icons were found installed but icon cache
 * has not been updated:
 *   /usr/share/icons/hicolor/32x32/mimetypes/image-vnd.djvu.png
 *   /usr/share/icons/hicolor/22x22/mimetypes/image-vnd.djvu.png
 *   /usr/share/icons/hicolor/48x48/mimetypes/image-vnd.djvu.png
 *   /usr/share/icons/hicolor/64x64/mimetypes/image-vnd.djvu.png
 * Please make sure to call xdg_icon_cache_update()
 * in pkg_postinst() and pkg_postrm() phases of appropriate pkgs.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-03-05 09:11:43 UTC
Also ebuilds misuse optfeature() function (from eutils.eclass).

optfeature() already internally calls has_version() and includes "for" in the printed message.
First argument of optfeature() should be a noun clause not preceded by any preposition.

app-text/djvu ebuilds have:
        optfeature "For djviewer or browser plugin" app-text/djview

This results in this ugly message:
 *   app-text/djview for For djviewer or browser plugin
                     ^^^^^^^


-    has_version app-text/djview || \
-        optfeature "For djviewer or browser plugin" app-text/djview
+    elog "Packages needed for optional features:"
+    optfeature "djviewer or browser plugin" app-text/djview
Comment 2 Larry the Git Cow gentoo-dev 2019-11-12 07:01:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf46548bc8b86087b9bbef8e6c2b3d3cfd5732ae

commit cf46548bc8b86087b9bbef8e6c2b3d3cfd5732ae
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-11-12 06:59:15 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-11-12 06:59:15 +0000

    app-text/djvu: Update icon cache
    
    Closes: https://bugs.gentoo.org/679498
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-text/djvu/djvu-3.5.27-r1.ebuild | 2 ++
 1 file changed, 2 insertions(+)