Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 679220 - media-gfx/gimp breaks application desktop name to zzz-gimp.desktop
Summary: media-gfx/gimp breaks application desktop name to zzz-gimp.desktop
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-03-02 08:13 UTC by Mart Raudsepp
Modified: 2025-03-18 19:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2019-03-02 08:13:47 UTC
Bug 321111 added a workaround for (accidentally) not defaulting to gimp for PDF files. This is not how defaults should be affected, and ever since this was done, all actual defaults set by gnome-session for GNOME sessions have been broken, because it kept referring to gimp.desktop, not zzz-gimp.desktop.
Maybe this was acceptable back in 2011 (sans not figuring to update these defauls), but these days desktop files are a very important identifier for GUI apps, and renaming it for a workaround is bad. Please consider removing this hack and relying on having PDF defaults set up per-desktop via proper *mimeapps.list files in /usr/share/applications

Note that changing it back now would now constitute a full application change for desktops again, and e.g. if someone has added zzz-gimp application to gnome-shell sidebase favorites, it'll disappear, as there's no zzz-gimp then. So maybe keep both for now, and remove the zzz or both once upstream does a (modern days) proper reverse DNS for the desktop file, e.g. org.gimp.Gimp.desktop

I'm going to add zzz-gimp to our defaults list for the time being, but it's not the only place potentially affected. All other things interacting with GUI applications via desktop files are assuming gimp.desktop as well.
Comment 1 Larry the Git Cow gentoo-dev 2019-03-02 09:25:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca48a3124cabb263143c84930d9c43358c83a567

commit ca48a3124cabb263143c84930d9c43358c83a567
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2019-03-02 09:23:41 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2019-03-02 09:24:10 +0000

    gnome-base/gnome-session: bump to 3.28.1, update MIME defaults
    
    Meson port. Supports consolekit together with systemd (so it could
    support booting up without systemd still having fallback to CK then),
    but also no session tracking at all. Express this in the ebuild for
    the time being, even though using null backend is probably bad. Will
    revisit once elogind support is added, but meanwhile this allows to
    have the package at least installed on non-systemd systems without
    relying on deprecated CK.
    Many X11 deps are gone with the meson port, and some since long ago
    with autotools, but not updated earlier.
    Also clean up some pure RDEPEND vs COMMON_DEPEND stuff (dbus-glib
    was wrongly in DEPEND only, xdg-user-dirs* was wrongly in COMMON_DEPEND).
    
    Update gnome-mimeapps.list with newer desktop files and fix some
    messup with brasero stuff, and zzz-gimp.desktop.
    
    Bug: https://bugs.gentoo.org/679220
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 gnome-base/gnome-session/Manifest                  |   1 +
 gnome-base/gnome-session/files/defaults.list-r4    | 335 +++++++++++++++++++++
 .../gnome-session/gnome-session-3.28.1.ebuild      | 114 +++++++
 gnome-base/gnome-session/metadata.xml              |   3 +
 4 files changed, 453 insertions(+)
Comment 2 Pacho Ramos gentoo-dev 2019-06-03 10:32:27 UTC
Personally I would simply drop old zzz-gimp.desktop in favor of default one. I know it will cause the .desktop to disappear from people that added it to their desktop/docks, but I think it is really easy to get the icons back. We could simply add an ewarn telling people that .desktop file was renamed and I think they will simply readd it if needed
Comment 3 Chris Mayo 2024-11-16 17:06:22 UTC
When gimp is started from the command line, the installation of zzz-gimp.desktop prevents the DE from making the association, displaying for gimp the generic icon and "gimp" as the title.
Comment 4 Pacho Ramos gentoo-dev 2025-02-21 13:16:04 UTC
(In reply to Pacho Ramos from comment #2)
> Personally I would simply drop old zzz-gimp.desktop in favor of default one.
> I know it will cause the .desktop to disappear from people that added it to
> their desktop/docks, but I think it is really easy to get the icons back. We
> could simply add an ewarn telling people that .desktop file was renamed and
> I think they will simply readd it if needed

Maybe this could be dropped from 3.0_rc* versions. As final 3.0 is coming, maybe it's a good opportunity to finally drop the old zzz desktop file

Thanks
Comment 5 Larry the Git Cow gentoo-dev 2025-03-18 19:23:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a71f8186fffc22dbcda9bd7c4943fb33a78d628

commit 7a71f8186fffc22dbcda9bd7c4943fb33a78d628
Author:     Sergey Torokhov <torokhov-s-a@yandex.ru>
AuthorDate: 2025-03-18 19:01:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-18 19:22:31 +0000

    media-gfx/gimp: 3.0.0 version bump
    
    QA warning is presented:
    QA Notice: Package triggers severe warnings which indicate that it                                                                                                                                             │
               may exhibit random runtime failures.                                                                                                                                                                │
    extensions/goat-exercises/goat-exercise-vala.p/goat-exercise-vala.c:303:24:
    warning: assignment to ‘GtkBox *’ {aka ‘struct _GtkBox *’}
    from incompatible pointer type ‘GtkWidget *’ {aka ‘struct _GtkWidget *’}
    [-Wincompatible-pointer-types]
    
    Still affected "fails test "gimp:app / core" TIMEOUT" issue (936290)
    
    Remove workaround with renaming to zzz-gimp.desktop (#679220)
    
    Bug: https://bugs.gentoo.org/936290
    Closes: https://bugs.gentoo.org/679220
    Bug: https://bugs.gentoo.org/947607
    Bug: https://bugs.gentoo.org/769350
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/gimp/Manifest          |   1 +
 media-gfx/gimp/gimp-3.0.0.ebuild | 258 +++++++++++++++++++++++++++++++++++++++
 media-gfx/gimp/gimp-9999.ebuild  |   4 -
 3 files changed, 259 insertions(+), 4 deletions(-)