Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678498 - sys-kernel/gentoo-sources: Excluding Patch #5010_enable-additional-cpu-optimizations-for-gcc.patch ...
Summary: sys-kernel/gentoo-sources: Excluding Patch #5010_enable-additional-cpu-optimi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
: 678488 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-02-21 14:58 UTC by Peter
Modified: 2019-03-06 15:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
USE=-experimental (experimental_off,11.47 KB, text/plain)
2019-02-21 22:37 UTC, Peter
Details
USE=experimental (experimental_on,14.27 KB, text/plain)
2019-02-21 22:38 UTC, Peter
Details
USE=experimental on 4.19.23 (experimental_on_point_23,11.90 KB, text/plain)
2019-02-21 23:12 UTC, Peter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter 2019-02-21 14:58:42 UTC
Hi, I'm on stable keywords and have the experimental useflag enabled. This used to enable among other things, the ability to select CONFIG_MNATIVE for the processor type. However, very recently, this changed and when emerging the kernel I gets:

>>> Unpacking genpatches-4.19-23.experimental.tar.xz to /var/tmp/portage/sys-ker
 * Excluding Patch #5010_enable-additional-cpu-optimizations-for-gcc.patch ...
 * Excluding Patch #5011_enable-cpu-optimizations-for-gcc8.patch ...
 * Excluding Patch #5010_enable-additional-cpu-optimizations-for-gcc.patch ...
 * Excluding Patch #5011_enable-cpu-optimizations-for-gcc8.patch ...
 * Excluding Patch #5010_enable-additional-cpu-optimizations-for-gcc.patch ...
 * Excluding Patch #5011_enable-cpu-optimizations-for-gcc8.patch ...
 * Applying 1000_linux_4.19.1.patch (-p1) ...
 * Applying 1001_linux-4.19.2.patch (-p1) ...
 * Applying 1002_linux-4.19.3.patch (-p1) ...

Like I say, I'm on stable so have gcc-7.3.0-r3, so the 5010 patches should be applied?
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-02-21 17:02:42 UTC
*** Bug 678488 has been marked as a duplicate of this bug. ***
Comment 3 Mike Pagano gentoo-dev 2019-02-21 22:16:30 UTC
Can you run and attach the full output of:

ECLASS_DEBUG_OUTPUT=on USE=experimental ebuild gentoo-sources-4.19.24.ebuild clean unpack

and

ECLASS_DEBUG_OUTPUT=on USE=-experimental ebuild gentoo-sources-4.19.24.ebuild clean unpack
Comment 4 Peter 2019-02-21 22:37:45 UTC
Created attachment 566046 [details]
USE=-experimental
Comment 5 Peter 2019-02-21 22:38:17 UTC
Created attachment 566048 [details]
USE=experimental
Comment 6 Mike Pagano gentoo-dev 2019-02-21 23:05:57 UTC
Looks like 5010 is applied with use=experimental 

<snip>

 * Applying 4567_distro-Gentoo-Kconfig.patch (-p1) ...                                                    [ ok ]
 * Applying 5010_enable-additional-cpu-optimizations-for-gcc-4.9.patch (-p1) ...                          [ ok ]
debug: Doing premake

<snip>


and not applied with use=-experimental

<snip>
 * Applying 4400_alpha-sysctl-uac.patch (-p1) ...                                                         [ ok ]
 * Applying 4567_distro-Gentoo-Kconfig.patch (-p1) ...                                                    [ ok ]
debug: Doing premake
debug: Doing unpack_set_extraversion
<snip>

Is there an issue here I am missing ?
Comment 7 Peter 2019-02-21 23:12:46 UTC
Created attachment 566052 [details]
USE=experimental on 4.19.23
Comment 8 Peter 2019-02-21 23:16:20 UTC
Hi Mike, the possible bug was with .23 (just attached as 'USE=experimental on 4.19.23') rather than .24. Stable kernels have worked previously (4.14.83) with MNATIVE being available from menuconfig. Is .23 not supposed to have that?
Comment 9 Mike Pagano gentoo-dev 2019-02-21 23:22:10 UTC
Yeah, I probably broke that.

I'll take a look.
Comment 10 Mike Pagano gentoo-dev 2019-02-22 00:13:43 UTC
Yeah, my bad.

I just committed a fix to kernel-2.eclass a few seconds ago.

It will take a little time to get to the mirrors but it was a one line
change.

You can get the new file right away directly from here:
https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/kernel-2.eclass?id=d71fe9c18bd7fe412185f3ca79379c631bde79b2


Otherwise, wait a bit, then sync and give it a try and report back if you don't mind.
Comment 11 hanetzer 2019-02-22 01:04:19 UTC
Just got hit by this myself for gentoo-sources-4.20.11
Even with having commit d71fe9c18bd7fe412185f3ca79379c631bde79b2
and sys-devel/gcc-8.2.0-r6 the patch is not being applied.
Expected behavior or still broken?
Comment 12 Peter 2019-02-22 09:06:20 UTC
That works for me Mike, I gave it a go with the amd64 stable 4.14.83, 4.14.101, 4.19.23, and latest - 4.20.11, 5010 is being applied to all of these when experimental is on, and not when experimental is off.

Thank you, that was a super-responsive fix.
Comment 13 Peter 2019-02-22 10:01:54 UTC
(In reply to hanetzer from comment #11)
> Just got hit by this myself for gentoo-sources-4.20.11
> Even with having commit d71fe9c18bd7fe412185f3ca79379c631bde79b2
> and sys-devel/gcc-8.2.0-r6 the patch is not being applied.
> Expected behavior or still broken?

Hey there, that sounds like https://bugs.gentoo.org/678556 rather than this bug.
Comment 14 Mike Pagano gentoo-dev 2019-02-22 12:25:54 UTC
This one is fixed so I'm going to close it.

For everyone that has gcc v8 and wants to follow along with the progress for the cpu optimization patch for >= 4.20 please go to bug #678556 .