Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678490 - net-ftp/proftpd: crashes on HUP signal
Summary: net-ftp/proftpd: crashes on HUP signal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-21 10:51 UTC by Hanno Böck
Modified: 2019-02-22 21:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2019-02-21 10:51:03 UTC
There's an upstream bug in ProFTPD that will make it exit if you send the process a HUP signal.
I observed this on some of my servers and it took quite some digging to figure out what's happening there and why the proftpd would occasionally just terminate, so I believe it would be good to patch this to spare others the bug searching.

This is fixed upstream, but they don't seem to be eager to get out new releases fast (last one was in 2017), therefore I'd suggest to patch this in our ebuilds.

Here's the upstream bug:
http://bugs.proftpd.org/show_bug.cgi?id=4310

Here's the relevant commit / patch:
https://github.com/proftpd/proftpd/commit/345aa19ee2a98a3612d9b64a49107461455031a0.patch

(There's a second commit in the pull request fixing this bug removing unnecessary variables, but this is just cosmetic and doesn't change functionality, so no strong need to backport that)
Comment 1 Larry the Git Cow gentoo-dev 2019-02-22 21:00:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66357ee093d02b0c26c12dcd37cf0a010ba92525

commit 66357ee093d02b0c26c12dcd37cf0a010ba92525
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-02-22 21:00:11 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-02-22 21:00:25 +0000

    net-ftp/proftpd: apply SIGHUP crash fix, bug #678490
    
    It's a upstream fix picked as-is from 1.3.6 branch.
    
    Reported-by: Hanno Boeck
    Closes: https://bugs.gentoo.org/678490
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 .../proftpd/files/proftpd-1.3.6-sighup-crash.patch |  81 +++++++
 net-ftp/proftpd/proftpd-1.3.6-r3.ebuild            | 267 +++++++++++++++++++++
 2 files changed, 348 insertions(+)
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2019-02-22 21:05:51 UTC
Yeah, we haven't seen proftpd releases in a while. tj@, WDYT of cutting one?

Pushed the patch as-is. Thank you!