Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678402 - net-im/dino-9999 - add support for slotted vala
Summary: net-im/dino-9999 - add support for slotted vala
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andriy Utkin (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-19 19:51 UTC by Daniel Kenzelmann
Modified: 2019-02-20 10:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kenzelmann 2019-02-19 19:51:58 UTC
ebuild is looking for valac which does by default not exist (not installed by vala)

Solution as per https://bugs.gentoo.org/338067 :
provide correct executable name.

The following diff works for me:

--- a/dino-9999.ebuild	2019-02-18 20:39:34.000000000 +0100
+++ b/dino-9999.ebuild	2019-02-19 20:47:17.577053733 +0100
@@ -47,6 +47,7 @@
 
 src_prepare() {
 	cmake-utils_src_prepare
+	vala_src_prepare
 }
 
 src_configure() {
@@ -57,6 +58,7 @@
 	)
 	local mycmakeargs+=(
 		"-DDISABLED_PLUGINS=$(local IFS=";"; echo "${disabled_plugins[*]}")"
+		-DVALA_EXECUTABLE="${VALAC}"
 	)
 
 	if has test ${FEATURES}; then


Reproducible: Always
Comment 1 Andriy Utkin (RETIRED) gentoo-dev 2019-02-20 01:22:50 UTC
Hi Daniel,

What is the problem which you have experienced?

For me, the ebuild works as-is, the build system manages to invoke vala-0.36 somehow.
Comment 2 Daniel Kenzelmann 2019-02-20 07:48:35 UTC
I would have to get the output again later today..

The problem is that it does not find vala (valac)
There are two ways to make it find it:
1. create link called valac to valac-0.42.5
2. specify the valac name in the options (that's what the patch does)

The reason why it would find it for you I think has to do with that it hase some fallback to a versioned binary in case it does not find the unversioned (i.e. it is looking for valac then maybe for valac-0.36, which is the lowest supported version, potentially it does maybe also check for some other versions like 0.40 etc, just not the latest version I have installed)

To test, do the following:
- Update to vala-0.42.5
- Ensure that you do not have a manual symlink to valac-0.42.5 (it is NOT installed by vala itself)
- emerge dino
Comment 3 Andriy Utkin (RETIRED) gentoo-dev 2019-02-20 10:31:08 UTC
Thanks, i reproduced the problem. Will apply the suggested patch.
Comment 4 Larry the Git Cow gentoo-dev 2019-02-20 10:56:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac688e86083db94f0461d6ccb3ec5c3de25d084e

commit ac688e86083db94f0461d6ccb3ec5c3de25d084e
Author:     Andrey Utkin <andrey_utkin@gentoo.org>
AuthorDate: 2019-02-20 10:56:05 +0000
Commit:     Andrey Utkin <andrey_utkin@gentoo.org>
CommitDate: 2019-02-20 10:56:31 +0000

    net-im/dino: specify valac for build system to use
    
    Before, dino's cmake scripts just searched for unversioned valac, and
    versioned ones with versions in the range 0.32 - 0.38.
    
    There are good reasons to let Portage decide which valac to use.
    
    * Now we have 0.40 and 0.42 in Gentoo tree. These are not detected by
      dino build system (bug 678402).
    * Allow users to override valac version uniformly across Gentoo with
      VALAC envvar.
    
    Suggested-by: Daniel Kenzelmann <gentoo@k8n.de>
    Bug: https://bugs.gentoo.org/678402
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Andrey Utkin <andrey_utkin@gentoo.org>

 net-im/dino/dino-9999.ebuild | 2 ++
 1 file changed, 2 insertions(+)
Comment 5 Andriy Utkin (RETIRED) gentoo-dev 2019-02-20 10:57:38 UTC
Thanks again for the report and the patch.