Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 678204 - =www-client/firefox-60.5.1 - Unified_cpp_tools_profiler0.o: {standard input}: Assembler messages: {standard input}:488: Error: bad expression -- `b #_ZL14SigprofHandleriP9siginfo_tPv'
Summary: =www-client/firefox-60.5.1 - Unified_cpp_tools_profiler0.o: {standard input}...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL: https://phabricator.services.mozilla....
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-02-17 07:32 UTC by tt_1
Modified: 2019-03-20 16:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.gz (build.log.gz,180.64 KB, application/gzip)
2019-02-17 07:32 UTC, tt_1
Details
output of emerge --info (emerge-info,5.29 KB, text/plain)
2019-02-17 07:34 UTC, tt_1
Details
patch from debian (firefox-60.0-mozbg-1463035-Remove-MOZ_SIGNAL_TRAMPOLINE.-r-darchons.patch,3.17 KB, patch)
2019-02-17 07:44 UTC, tt_1
Details | Diff
compressed build log from firefox-65.0.1 (firefox-65.0.1-build.log.gz,237.75 KB, application/gzip)
2019-02-20 07:25 UTC, tt_1
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2019-02-17 07:32:54 UTC
Created attachment 565606 [details]
build.log.gz

this was most likely introduced by this commit: https://hg.mozilla.org/mozilla-central/rev/537f4d1d837a
Comment 1 tt_1 2019-02-17 07:34:18 UTC
Created attachment 565608 [details]
output of emerge --info
Comment 2 tt_1 2019-02-17 07:39:06 UTC
There is #1434526 at upstream, where this is discussed. It is caused by the intention to work around a bug in clang on arm, but it was solved at the cost of breaking compile with gcc. 

In #1463035 it is mentioned, that the whole workaround isn't needed anymore.
Comment 3 tt_1 2019-02-17 07:44:12 UTC
Created attachment 565610 [details, diff]
patch from debian

Simply reverting 537f4d1d837a makes the compile go with gcc, but it leads to a segfault. Also it breaks compile with clang, again. 

Debian decided to entirely remove the function, and it works fine for me. Both compilers, gcc and clang, produce a working binary on armv7-unknown-linux-gnueabihf, and I applied it via eapply_user on my amd64 box and had no problems either.
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2019-02-17 15:52:20 UTC
The patch was backed out one day later, https://hg.mozilla.org/integration/autoland/rev/0ee7d4aa1799, so we are not going to add the proposed one.
Comment 5 tt_1 2019-02-18 11:34:10 UTC
I had no idea this was attempted to land at upstream. Is there another bug open which I didn't got?
Comment 6 tt_1 2019-02-18 13:18:49 UTC
ok, it's directly from #1463035 where the patch is backed out. I'm sorry, haven't noticed before. Lets keep it open for tracking, ok? 

Whoever needs it can apply it via eapply_user
Comment 7 tt_1 2019-02-20 07:25:08 UTC
Created attachment 565932 [details]
compressed build log from firefox-65.0.1

There is a similar failure with firefox-65.0.1, but this time its in hunspell. system-hunspell was dropped in 62 or 63, so I'll try to apply the patch from #3 to find out more about this.
Comment 8 tt_1 2019-02-21 19:48:11 UTC
v65.0.1 emerged with the same patch applied, and gcc as a compiler. Memory requirements have risen, it needs some 2.5gb at peak with -j2
Comment 9 tt_1 2019-03-20 11:47:23 UTC
it seems there is a fix in autoland? 

https://hg.mozilla.org/integration/autoland/rev/a8e6586172fd
Comment 10 Larry the Git Cow gentoo-dev 2019-03-20 15:52:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5548320f5a3160b9134274850f6ea76e90ad5fa

commit d5548320f5a3160b9134274850f6ea76e90ad5fa
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-03-20 15:49:51 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-03-20 15:51:59 +0000

    www-client/firefox: unbreak arm
    
    Add some patches to fix building on arm.
    
    Closes: https://bugs.gentoo.org/681036
    Closes: https://bugs.gentoo.org/678204
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/Manifest               | 2 +-
 www-client/firefox/firefox-66.0-r1.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 11 tt_1 2019-03-20 16:22:36 UTC
thanks!

can you please add the fix to esr as well? Maybe could be included into the bump to 60.6.0?
Comment 12 Thomas Deutschmann (RETIRED) gentoo-dev 2019-03-20 16:26:47 UTC
Yes, it's scheduled for 60.6 patch set.