Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 677972 - app-i18n/ibus-1.5.19 - emojier.vala:915.48-916.62: error: Assignment: Cannot convert from `GLib.SList<string>' to `GLib.SList<weak string>?'
Summary: app-i18n/ibus-1.5.19 - emojier.vala:915.48-916.62: error: Assignment: Cannot ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: CJK Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-02-14 10:38 UTC by Cynede (RETIRED)
Modified: 2019-03-02 12:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log of reporter of this bug (ibus-1.5.19.log,143.88 KB, text/plain)
2019-02-15 01:11 UTC, Arfrever Frehtes Taifersar Arahesis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cynede (RETIRED) gentoo-dev 2019-02-14 10:38:27 UTC
build fails with newer vala: https://bpaste.net/show/2fe42f8d633a

pull request: https://github.com/gentoo/gentoo/pull/11048
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-02-14 10:57:52 UTC
You should already be aware that you ought to attach the build log, not point to a paste site.
Comment 2 Mart Raudsepp gentoo-dev 2019-02-14 11:29:03 UTC
Please also look to making it actually work with newer vala. Old vala won't stick around forever. Hopefully upstream will take care of it though, if already hasn't in GIT (in which case consider grabbing the relevant patch(es) from there instead of limiting MAX; though unpatched revisions should get the MAX added)
Comment 3 Arfrever Frehtes Taifersar Arahesis 2019-02-15 01:11:52 UTC
Created attachment 565444 [details]
Build log of reporter of this bug
Comment 4 Larry the Git Cow gentoo-dev 2019-02-20 14:19:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b0c9ca2ac13b429d571a52becd533b73f7035cab

commit b0c9ca2ac13b429d571a52becd533b73f7035cab
Author:     Mikhail Pukhlikov <cynede@gentoo.org>
AuthorDate: 2019-02-14 08:45:28 +0000
Commit:     Akinori Hattori <hattya@gentoo.org>
CommitDate: 2019-02-20 14:18:55 +0000

    app-i18n/ibus: limit max vala version, add python3.7
    
    Closes: https://bugs.gentoo.org/677972
    Closes: https://github.com/gentoo/gentoo/pull/11048
    Signed-off-by: Mikhail Pukhlikov <cynede@gentoo.org>
    Signed-off-by: Akinori Hattori <hattya@gentoo.org>
    Package-Manager: Portage-2.3.60, Repoman-2.3.12

 app-i18n/ibus/ibus-1.5.19.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 cyrillic 2019-02-21 13:21:00 UTC
The trouble is in the emoji part of the code.

app-i18n/ibus-1.5.19[-emoji] works just fine with the latest vala.
Comment 6 Larry the Git Cow gentoo-dev 2019-02-25 12:46:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4967740ab488283e7caf3e4e651bc00e2eaf689e

commit 4967740ab488283e7caf3e4e651bc00e2eaf689e
Author:     Akinori Hattori <hattya@gentoo.org>
AuthorDate: 2019-02-25 12:43:07 +0000
Commit:     Akinori Hattori <hattya@gentoo.org>
CommitDate: 2019-02-25 12:45:08 +0000

    app-i18n/ibus: fix build with >=dev-lang/vala-0.43.4
    
    Bug: https://bugs.gentoo.org/677972
    Signed-off-by: Akinori Hattori <hattya@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 app-i18n/ibus/files/ibus-1.5.19-vala-0.43.4.patch | 191 ++++++++++++++++++++++
 app-i18n/ibus/ibus-1.5.19.ebuild                  |   6 +-
 2 files changed, 195 insertions(+), 2 deletions(-)
Comment 7 Mart Raudsepp gentoo-dev 2019-02-25 15:07:22 UTC
1.5.18 in stable isn't patched, nor does it set a VALA_MAX_API_VERSION.
To not have to worry about this breaking if a newer vala happens to be stabilized before ibus-1.5.19 - please put an appropriate VALA_MAX_API_VERSION in the 1.5.18 ebuild.
That said, looking at the patch, it looks like there actually is no issues with in-tree vala versions, given that the patch is for vala-0.43 dev release (which Cynede uses via his overlay), not for 0.42 or older. If so, VALA_MAX_API_VERSION="0.42" in the 1.5.18 ebuild won't hurt either (we'll have 0.44 in main tree only in March probably as that's when stable version comes out, but will take at least a month to stabilize, etc).
Comment 8 Larry the Git Cow gentoo-dev 2019-03-02 12:31:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bc567f091355a2bb2376b5b07d00680a9cbe42e1

commit bc567f091355a2bb2376b5b07d00680a9cbe42e1
Author:     Akinori Hattori <hattya@gentoo.org>
AuthorDate: 2019-03-02 12:29:22 +0000
Commit:     Akinori Hattori <hattya@gentoo.org>
CommitDate: 2019-03-02 12:29:22 +0000

    app-i18n/ibus: restrict >=dev-lang/vala-0.44
    
    Bug: https://bugs.gentoo.org/677972
    Signed-off-by: Akinori Hattori <hattya@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 app-i18n/ibus/ibus-1.5.18.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)