Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 677888 - sys-devel/llvm[gold] should depend on || ( >=sys-devel/binutils-2.31.1-r4:*[gold,plugins] <sys-devel/binutils-2.31.1-r4:*[cxx] )
Summary: sys-devel/llvm[gold] should depend on || ( >=sys-devel/binutils-2.31.1-r4:*[g...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: LLVM support project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 678766
  Show dependency tree
 
Reported: 2019-02-13 17:33 UTC by Johannes Hirte
Modified: 2019-05-15 13:00 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (llvm.patch,8.98 KB, patch)
2019-02-15 00:18 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff
Patch (llvm.patch,9.06 KB, patch)
2019-02-15 00:31 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Hirte 2019-02-13 17:33:21 UTC
Changing the use-flag from cxx to gold for sys-devel/binutils breaks sys-devel/llvm ebuild (see https://bugs.gentoo.org/663776)

sys-devel/llvm needs to be adapted for this too
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-02-14 10:59:29 UTC
It would be really nice if people who apparently were completely aware of the breakage they're introducing cared enough to actually fix this instead of expecting me to come out of sick leave to fix their mess without even caring to tell me.
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2019-02-14 22:11:34 UTC
(In reply to Michał Górny from comment #1)
> It would be really nice if people who apparently were completely aware of
> the breakage they're introducing

Put the names in 'people'. No need to obfuscate the blame contest if you want some action back. Below I assume you meant me.

> aware of the breakage they're introducing

I am unaware of any breakages.

Old IUSE=+cxx and new IUSE="+gold +plugins" are both enabled by default. The only systems could "break" is USE="-* [or] -gold/-plugins" systems. Which is an interesting combination to come by given that llvm[gold] pulls in binutils[cxx].

> cared enough to actually fix this

I do care enough not to butcher llvm ebuild without llvm@ oversight and wait for an input from llvm@.

> instead of expecting me to come out of sick leave to fix their mess

I don't expect you to come out of sick leave. Do take all the time you need.

I'll restore transitional
    USE=+cxx REQUIRED_USE="cxx? ( plugins gold )"

But I still expect llvm@ to adapt to new flags.

https://wiki.gentoo.org/wiki/Project:LLVM lists 6 people. You might want to assign someone explicitly to handle maintenance questions.

> without even caring to tell me.

llvm@ was CCed in bug #663776. You might want to set email filters up.
Comment 3 Larry the Git Cow gentoo-dev 2019-02-14 22:17:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=39d937a0feb6af576c2c751e44afce92452960d7

commit 39d937a0feb6af576c2c751e44afce92452960d7
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-02-14 22:17:29 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-02-14 22:17:29 +0000

    sys-devel/binutils: temporary restore transitional IUSE=+cxx flag
    
    Temporary restore IUSE=+cxx to help llvm. IUSE=+cxx will still go
    away soon.
    
    Reported-by: Johannes Hirte
    Bug: https://bugs.gentoo.org/677888
    Bug: https://bugs.gentoo.org/663776
    Package-Manager: Portage-2.3.60, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-devel/binutils/binutils-2.31.1-r4.ebuild | 6 ++++--
 sys-devel/binutils/binutils-9999.ebuild      | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)
Comment 4 Arfrever Frehtes Taifersar Arahesis 2019-02-15 00:18:08 UTC
Created attachment 565436 [details, diff]
Patch

Since <sys-devel/binutils-2.22 is long gone, this patch does not care about it.
Comment 5 Arfrever Frehtes Taifersar Arahesis 2019-02-15 00:31:05 UTC
Since sys-devel/llvmgold installs symlink in /usr/${CHOST}/binutils-bin/lib/bfd-plugins directory, it is more probably that USE="plugins" also needs to be enabled for sys-devel/binutils.
Comment 6 Arfrever Frehtes Taifersar Arahesis 2019-02-15 00:31:33 UTC
Created attachment 565440 [details, diff]
Patch
Comment 7 tt_1 2019-02-15 06:40:34 UTC
It would be great if the info for the new 'tools' flag in the metadata file was updated to something more verbose. No idea what it does? :)
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-02-26 07:49:54 UTC
Hmm, wouldn't the dep on [plugins] be sufficient?  I think the LLVMgold plugin is going to work for bfd as well.
Comment 9 Larry the Git Cow gentoo-dev 2019-03-13 08:22:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f7a7694538ef2e256e1d3cb94da1cb391df9c31

commit 1f7a7694538ef2e256e1d3cb94da1cb391df9c31
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-03-13 07:47:09 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-03-13 07:47:11 +0000

    sys-devel/llvm: Update binutils dep in live ebuilds & RC
    
    Update binutils dependency to account for USE flag rename in live
    ebuilds and the masked RC.  ~arch ebuilds are going to be updated
    as new releases are added to avoid spurious rebuilds.
    
    Bug: https://bugs.gentoo.org/677888
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 sys-devel/llvm/llvm-7.0.9999.ebuild  | 7 ++++++-
 sys-devel/llvm/llvm-8.0.0_rc5.ebuild | 7 ++++++-
 sys-devel/llvm/llvm-8.0.9999.ebuild  | 7 ++++++-
 sys-devel/llvm/llvm-9999.ebuild      | 7 ++++++-
 4 files changed, 24 insertions(+), 4 deletions(-)
Comment 10 Larry the Git Cow gentoo-dev 2019-04-19 18:43:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=553387da4b61af13df1d81eb400554f30195a713

commit 553387da4b61af13df1d81eb400554f30195a713
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-04-19 18:42:37 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-04-19 18:43:18 +0000

    sys-devel/llvm: Update binutils dep in 7.1.0
    
    Bug: https://bugs.gentoo.org/677888
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 sys-devel/llvm/llvm-7.1.0.ebuild | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Comment 11 Larry the Git Cow gentoo-dev 2019-05-15 13:00:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f891340b59a9f47a3747dfd8c02c9e6be9c9653

commit 1f891340b59a9f47a3747dfd8c02c9e6be9c9653
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-05-15 12:59:22 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-05-15 12:59:47 +0000

    sys-devel/llvm: Update binutils dep in remaining versions
    
    Closes: https://bugs.gentoo.org/677888
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 sys-devel/llvm/llvm-4.0.1-r1.ebuild | 7 ++++++-
 sys-devel/llvm/llvm-5.0.2.ebuild    | 7 ++++++-
 sys-devel/llvm/llvm-6.0.1-r2.ebuild | 7 ++++++-
 sys-devel/llvm/llvm-6.0.1.ebuild    | 7 ++++++-
 4 files changed, 24 insertions(+), 4 deletions(-)