Bug 677802 – net-misc/freerdp-2.0.0_rc4[debug] - .../work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c:505:3: error: too few arguments to function ‘ntlm_print_av_pair_list’

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description ernsteiswuerfel 2019-02-12 15:04:08 UTC]

Created attachment 564930 [details]
build.log

[...]
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c: In function ‘ntlm_read_ChallengeMessage’:
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c:505:3: error: too few arguments to function ‘ntlm_print_av_pair_list’
   ntlm_print_av_pair_list(context->ChallengeTargetInfo.pvBuffer);
   ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_compute.h:25:0,
                 from /var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c:32:
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.h:28:6: note: declared here
 void ntlm_print_av_pair_list(NTLM_AV_PAIR* pAvPairList, size_t cbAvPairList);
      ^~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c: In function ‘ntlm_read_AuthenticateMessage’:
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c:889:2: error: too few arguments to function ‘ntlm_print_av_pair_list’
  ntlm_print_av_pair_list(context->NTLMv2Response.Challenge.AvPairs);
  ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_compute.h:25:0,
                 from /var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c:32:
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.h:28:6: note: declared here
 void ntlm_print_av_pair_list(NTLM_AV_PAIR* pAvPairList, size_t cbAvPairList);
      ^~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c: In function ‘ntlm_write_AuthenticateMessage’:
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c:1096:3: error: too few arguments to function ‘ntlm_print_av_pair_list’
   ntlm_print_av_pair_list(context->AuthenticateTargetInfo.pvBuffer);
   ^~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_compute.h:25:0,
                 from /var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_message.c:32:
/var/tmp/portage/net-misc/freerdp-2.0.0_rc4/work/freerdp-2.0.0-rc4/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.h:28:6: note: declared here
 void ntlm_print_av_pair_list(NTLM_AV_PAIR* pAvPairList, size_t cbAvPairList);
      ^~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [winpr/libwinpr/CMakeFiles/winpr.dir/build.make:2871: winpr/libwinpr/CMakeFiles/winpr.dir/sspi/NTLM/ntlm_message.c.o] Error 1

[Comment 1 ernsteiswuerfel 2019-02-12 15:05:08 UTC]

Created attachment 564932 [details]
emerge --info

[Comment 2 Mike Gilbert 2019-02-12 18:08:12 UTC]

Please disable the "debug" USE flag to work around this for now.

You probably don't want debug enabled anyway unless you are actively developing the software or troubleshooting some obscure issue.

[Comment 3 Mike Gilbert 2019-02-12 18:11:29 UTC]

This should be fixed in the next release. I probably will not bother back-porting the fix.

[Comment 4 ernsteiswuerfel 2019-02-12 18:23:57 UTC]

(In reply to Mike Gilbert from comment #2)
> Please disable the "debug" USE flag to work around this for now.
> 
> You probably don't want debug enabled anyway unless you are actively
> developing the software or troubleshooting some obscure issue.
Correct. Just wanted to do that (bug #672744) to get some meaningful debug output. ;)

Thanks für the update!

[Comment 5 Mike Gilbert 2019-02-12 18:39:29 UTC]

Ah, well you could apply the changes from the pull request locally to get the debug USE flag working.

[Comment 6 Larry the Git Cow 2019-12-31 17:26:39 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73281ba3a184dc071d6e52ec032ba0dd9960b44e

commit 73281ba3a184dc071d6e52ec032ba0dd9960b44e
Author:     Mike Gilbert <[e-mail]>
AuthorDate: 2019-12-31 17:25:11 +0000
Commit:     Mike Gilbert <[e-mail]>
CommitDate: 2019-12-31 17:26:35 +0000

    net-misc/freerdp: new snapshot
    
    Closes: https://bugs.gentoo.org/677802
    Closes: https://bugs.gentoo.org/703612
    Package-Manager: Portage-2.3.84_p2, Repoman-2.3.20_p24
    Signed-off-by: Mike Gilbert <[e-mail]>

 net-misc/freerdp/Manifest                       |   1 +
 net-misc/freerdp/freerdp-2.0.0_rc4_p1129.ebuild | 122 ++++++++++++++++++++++++
 net-misc/freerdp/freerdp-9999.ebuild            |   2 +-
 3 files changed, 124 insertions(+), 1 deletion(-)