Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 677788 - sys-kernel/dracut-049-r1 - modules.d/35network-manager/nm-run.sh uses basename but does not require it
Summary: sys-kernel/dracut-049-r1 - modules.d/35network-manager/nm-run.sh uses basenam...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL: https://github.com/dracutdevs/dracut/...
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2019-02-12 08:40 UTC by Dennis Schridde
Modified: 2019-12-29 19:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dracut-049-network-manager-dependencies.patch (dracut-049-network-manager-dependencies.patch,600 bytes, patch)
2019-02-12 08:40 UTC, Dennis Schridde
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2019-02-12 08:40:32 UTC
Created attachment 564922 [details, diff]
dracut-049-network-manager-dependencies.patch

modules.d/35network-manager/nm-run.sh uses `basename`, but the accompanying module-setup.sh does not require it.

How to reproduce: On my system, sometimes bcache activation hangs forever, which will make `99-nm-run.sh` start before the new rootfs is online.  The console will then log lots of lines similar to: basename - no such file or directory.

Attached patch should fix this.  (Applies cleanly, not yet tested)
Comment 1 Mike Gilbert gentoo-dev 2019-02-12 13:06:23 UTC
Send patches upstream please.
Comment 2 Dennis Schridde 2019-02-12 13:31:48 UTC
(In reply to Mike Gilbert from comment #1)
> Send patches upstream please.

https://github.com/dracutdevs/dracut/issues/537
Comment 3 Larry the Git Cow gentoo-dev 2019-12-29 19:39:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=980830b7e4a2953550338f13dd8525bcad28d8fc

commit 980830b7e4a2953550338f13dd8525bcad28d8fc
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2019-12-26 14:26:15 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-12-29 19:36:23 +0000

    sys-kernel/dracut: Add a bunch of upstream patches
    
    * fix dracut-install crashes
    * install kernel module dependencies of dependencies
    * add support for compressed firmware files
    * add support for rngd service
    * bash-5 compatibility
    * add fts-standalone dependency and configure check for musl
    * fix udevdir detection
    
    Closes: https://bugs.gentoo.org/676268
    Closes: https://bugs.gentoo.org/677788
    Closes: https://bugs.gentoo.org/687602
    Bug: https://bugs.gentoo.org/703438
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-kernel/dracut/dracut-049-r3.ebuild             | 176 +++++++++++++++++++++
 ...gure-find-cflags-and-libs-for-fts-on-musl.patch |  97 ++++++++++++
 ...t-create-locking-directory-run-cryptsetup.patch |  32 ++++
 ...all-Support-the-compressed-firmware-files.patch |  63 ++++++++
 .../049-dracut.sh-Fix-udevdir-detection.patch      |  38 +++++
 .../dracut/files/049-fs-lib-drop-a-bashism.patch   |  99 ++++++++++++
 ...cut-install.c-install-module-dependencies.patch |  79 +++++++++
 ...ing_hash_func-should-not-be-fed-with-NULL.patch |  38 +++++
 ...g-the-systemdutildir-variable-before-it-s.patch |  55 +++++++
 ...ager-call-the-online-hook-for-connected-d.patch |  32 ++++
 ...ager-fix-getting-of-ifname-from-the-sysfs.patch |  37 +++++
 ...rk-manager-remove-useless-use-of-basename.patch |  26 +++
 ...dule-running-early-during-boot-to-help-ge.patch |  88 +++++++++++
 13 files changed, 860 insertions(+)