Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 677712 - sci-libs/libmed-3.3.1 : [QA] One or more CMake variables were not used by the project:
Summary: sci-libs/libmed-3.3.1 : [QA] One or more CMake variables were not used by the...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Miroslav Šulc
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-11 13:04 UTC by Toralf Förster
Modified: 2019-03-02 09:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
etc.portage.tbz2 (etc.portage.tbz2,14.89 KB, application/x-bzip)
2019-02-11 13:04 UTC, Toralf Förster
Details
sci-libs:libmed-3.3.1:20190211-125449.log.bz2 (sci-libs:libmed-3.3.1:20190211-125449.log.bz2,29.17 KB, application/x-bzip)
2019-02-11 13:10 UTC, Toralf Förster
Details
libmed-3.3.1-installdoc.patch (libmed-3.3.1-installdoc.patch,1.00 KB, patch)
2019-02-26 10:56 UTC, Fabio Rossi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-02-11 13:04:00 UTC
QA: other
One or more CMake variables were not used by the project:
  MEDFILE_DOC_DIRECTORY

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-hardened_test_20190209-222026

  -------------------------------------------------------------------
Comment 1 Toralf Förster gentoo-dev 2019-02-11 13:04:03 UTC
Created attachment 564706 [details]
etc.portage.tbz2
Comment 2 Toralf Förster gentoo-dev 2019-02-11 13:10:16 UTC
Created attachment 564708 [details]
sci-libs:libmed-3.3.1:20190211-125449.log.bz2
Comment 3 Miroslav Šulc gentoo-dev 2019-02-11 21:16:49 UTC
this variable is introduced by a patch:

$ ebuild libmed-3.3.1.ebuild clean prepare
Appending /usr/src/gentoo.git to PORTDIR_OVERLAY...
 * med-3.3.1.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                                                                                                                                                                     [ ok ]
 * libmed-3.3.1-gentoo.tar.bz2 BLAKE2B SHA512 size ;-) ...                                                                                                                                                                                                                                                                                                          [ ok ]
>>> Unpacking source...
>>> Unpacking med-3.3.1.tar.gz to /var/tmp/portage/sci-libs/libmed-3.3.1/work
>>> Unpacking libmed-3.3.1-gentoo.tar.bz2 to /var/tmp/portage/sci-libs/libmed-3.3.1/work
>>> Source unpacked in /var/tmp/portage/sci-libs/libmed-3.3.1/work
>>> Preparing source in /var/tmp/portage/sci-libs/libmed-3.3.1/work/med-3.3.1_SRC ...
 * Applying libmed-3.3.1-cmake-fortran.patch ...                                                                                                                                                                                                                                                                                                                    [ ok ]
 * Applying libmed-3.3.1-disable-python-compile.patch ...                                                                                                                                                                                                                                                                                                           [ ok ]
 * Applying libmed-3.3.1-mpi.patch ...                                                                                                                                                                                                                                                                                                                              [ ok ]
 * Applying libmed-3.3.1-hdf5-1.10-support.patch ...                                                                                                                                                                                                                                                                                                                [ ok ]
 * Applying libmed-3.3.1-cmakelist.patch ...                                                                                                                                                                                                                                                                                                                        [ ok ]
 * Applying libmed-3.3.1-tests.patch ...                                                                                                                                                                                                                                                                                                                            [ ok ]
 * Applying libmed-3.3.1-tests-python3.patch ...                                                                                                                                                                                                                                                                                                                    [ ok ]
 * Applying libmed-3.3.1-installdoc.patch ...                                                                                                                                                                                                                                                                                                                       [ ok ]
 * Applying libmed-3.3.1-python-imports.patch ...                                                                                                                                                                                                                                                                                                                   [ ok ]
>>> Source prepared.


 $ grep MEDFILE_DOC_DIRECTORY /var/tmp/portage/sci-libs/libmed-3.3.1/work/* -r
/var/tmp/portage/sci-libs/libmed-3.3.1/work/libmed-3.3.1-installdoc.patch:+  set(MEDFILE_DOC_DIRECTORY ${CMAKE_INSTALL_PREFIX}/share CACHE PATH "install dir for documentation")
/var/tmp/portage/sci-libs/libmed-3.3.1/work/libmed-3.3.1-installdoc.patch:+  INSTALL(DIRECTORY doc/ DESTINATION ${MEDFILE_DOC_DIRECTORY}
/var/tmp/portage/sci-libs/libmed-3.3.1/work/med-3.3.1_SRC/CMakeLists.txt:  set(MEDFILE_DOC_DIRECTORY ${CMAKE_INSTALL_PREFIX}/share CACHE PATH "install dir for documentation")
/var/tmp/portage/sci-libs/libmed-3.3.1/work/med-3.3.1_SRC/CMakeLists.txt:  INSTALL(DIRECTORY doc/ DESTINATION ${MEDFILE_DOC_DIRECTORY}


not sure what to do about it to fix the warning.
Comment 4 Fabio Rossi 2019-02-26 10:56:05 UTC
I made the patch to install the documentation in the correct path asked by PMS specs. Instead of patching the CMakeLists.txt it should be possible to manually fix the documentation directory later in src_install().

The warning appears because when building with USE="-doc" the statement defining MEDFILE_DOC_DIRECTORY is CMakeLists.txt is never reached. I am attaching here a reworked patch to address the issue.
Comment 5 Fabio Rossi 2019-02-26 10:56:41 UTC
Created attachment 566518 [details, diff]
libmed-3.3.1-installdoc.patch
Comment 6 Larry the Git Cow gentoo-dev 2019-03-02 09:33:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=18b904bd07f7dd67b3d490789cdd58edea334c5c

commit 18b904bd07f7dd67b3d490789cdd58edea334c5c
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2019-03-02 09:32:38 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2019-03-02 09:33:23 +0000

    sci-libs/libmed-3.3.1-r1: fixed bug #677712
    
    Signed-off-by: Fabio Rossi <rossi.f@inwind.it>
    Closes: https://bugs.gentoo.org/677712
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 sci-libs/libmed/Manifest                                        | 2 +-
 sci-libs/libmed/{libmed-3.3.1.ebuild => libmed-3.3.1-r1.ebuild} | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)