Bug 677678 – net-dialup/xl2tpd-1.3.12 - xl2tpd: This binary does not support kernel L2TP.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Paul Maddock 2019-02-10 19:57:02 UTC]

When starting xl2tpd-1.3.12 (same for stable xl2tpd-1.3.10) syslog advises that the binary does not support kernel L2TP.

Feb 10 19:08:01 router xl2tpd[302]: Not looking for kernel SAref support.
Feb 10 19:08:01 router xl2tpd[302]: This binary does not support kernel L2TP.
Feb 10 19:08:01 router xl2tpd[303]: xl2tpd version xl2tpd-1.3.12 started on router PID:303

Changing this in the ebuild

src_compile() {
        tc-export CC
        emake OSFLAGS="-DLINUX"
}

to

src_compile() {
    tc-export CC
    emake
}

builds xl2tpd with kernel l2tp support.

Feb 10 19:16:22 router xl2tpd[413]: Not looking for kernel SAref support.
Feb 10 19:16:22 router xl2tpd[413]: Using l2tp kernel support.
Feb 10 19:16:22 router xl2tpd[416]: xl2tpd version xl2tpd-1.3.12 started on router PID:416


When OSFLAGS isn't overridden in the ebuild it uses the following from the Makefile

OSFLAGS?= -DLINUX -I$(KERNELSRC)/include/
OSFLAGS+= -DUSE_KERNEL


Looking back through the older ebuilds, xl2tpd-1.3.1-r4.ebuild had a use flag "kernel" and had a src_compile as:

src_compile() {
	tc-export CC
	export OSFLAGS="-DLINUX"
	use kernel && OSFLAGS+=" -DUSE_KERNEL"
	emake
}


Was kernel support dropped for a reason or just accidentally?


Additional note. When kernel l2tp support is compiled in, it can be disable by setting "force userspace=yes" in the global section of the config file.

[Comment 1 Torsten Alex 2019-02-17 04:14:27 UTC]

This had already been addressed here <https://github.com/gentoo/gentoo/pull/10248>. Surprised to see the pull request still open.

Version bump to 1.3.13 pull request with kernel mode support is out: <https://github.com/gentoo/gentoo/pull/11084>

The reason kernel mode got removed for earlier is unknown to me. Good to know it can be turned off via config file option.

[Comment 2 Larry the Git Cow 2019-04-19 14:11:13 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f4ef075a03fc9bf9b2cf0b1ae4d9fda17b6c6058

commit f4ef075a03fc9bf9b2cf0b1ae4d9fda17b6c6058
Author:     Torsten Alex <[e-mail]>
AuthorDate: 2019-02-17 03:41:12 +0000
Commit:     Michał Górny <[e-mail]>
CommitDate: 2019-04-19 14:10:14 +0000

    net-dialup/xl2tpd: bump version to 1.3.13, readd kernel mode
    
    Closes: https://bugs.gentoo.org/677678
    Signed-off-by: Torsten Alex <[e-mail]>
    Package-Manager: Portage-2.3.51, Repoman-2.3.10
    Signed-off-by: Michał Górny <[e-mail]>

 net-dialup/xl2tpd/Manifest             |  1 +
 net-dialup/xl2tpd/metadata.xml         |  1 +
 net-dialup/xl2tpd/xl2tpd-1.3.13.ebuild | 48 ++++++++++++++++++++++++++++++++++
 3 files changed, 50 insertions(+)