* No Python implementation selected for the build. Please set * the PYTHON_TARGETS variable in your make.conf to include one * of the following values: * * python2_7 * ERROR: app-text/referencer-1.2.2::gentoo failed (setup phase): * No supported Python implementation in PYTHON_SINGLE_TARGET/PYTHON_TARGETS.
Created attachment 565710 [details] referencer-1.2.2.ebuild REQUIRED_USE="${PYTHON_REQUIRED_USE}" was added to the attached ebuild. other so far unmerged fixes from bug https://bugs.gentoo.org/673092 are also included (missing dependencies for tests, see https://bugs.gentoo.org/673092#c1 for details)
Thanks for your response. Advice for the future, attaching a unified diff instead of a full ebuild is much preferred as it makes reviewing on bugzilla easier. Now on to review: Your switch to xdg.eclass makes gnome2-utils and the calls to it unnecessary, it is all done by xdg.eclass and no need to even override pkg_post{inst,rm} then. eutils is nowhere used and can be dropped. >=dev-cpp/gtkmm-2.8:* :* looks wrong. You need to depend on 2.4 for sure, correlating with dev-cpp/libglademm which only exists for slot 2.4. >=dev-libs/boost-1.52.0-r4 this is very likely missing slot operator := to trigger rebuild on boost upgrade. app-text/docbook-xml-dtd:4.5 app-text/scrollkeeper-dtd:1.0 )" ^ both lines are indented one tab too much.
Created attachment 566204 [details] referencer-1.2.2.ebuild thanks for the review. I agree with the mentioned points and made according changes to the ebuild. I missed dropping the pkg_postinst/rm functions since the commit to the xdg eclass somehow overlapped with my work on this. To summarize the changes: * add REQUIRED_USE="${PYTHON_REQUIRED_USE}" * add test dependencies * switch from xdg-utils to xdg eclass * drop unused eutils eclass * add subslot operator := for dev-libs/boost dependency will change to attaching diffs in future!
Thanks for your work! Please read through https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin and confirm that I can add your 'Signed-off-by: ' to the commit message.
I confirm that Signed-off-by: Dominik Kriegner <dominik.kriegner@gmail.com> Can be added. I woulp propose to mention also bug 673092 so that the commit shows up there as well.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6b0122795047cf8f68a69d6e02a29771d50cc6e commit f6b0122795047cf8f68a69d6e02a29771d50cc6e Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2019-02-24 22:12:16 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-02-24 22:13:47 +0000 app-text/referencer: Add USE test, missing ${PYTHON_REQUIRED_USE} Closes: https://bugs.gentoo.org/677514 Closes: https://bugs.gentoo.org/673092 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> app-text/referencer/referencer-1.2.2.ebuild | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-)
(In reply to Dominik Kriegner from comment #5) > I confirm that > Signed-off-by: Dominik Kriegner <dominik.kriegner@gmail.com> > Can be added. I woulp propose to mention also bug 673092 so that the commit > shows up there as well. Sorry I messed up there wrt signoff.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=17175b13edcf4d3dc0aa602127664f629264db21 commit 17175b13edcf4d3dc0aa602127664f629264db21 Author: Dominik Kriegner <dominik.kriegner@gmail.com> AuthorDate: 2019-02-24 22:12:16 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2019-02-24 22:31:53 +0000 app-text/referencer: Add USE test, missing ${PYTHON_REQUIRED_USE} Closes: https://bugs.gentoo.org/677514 Closes: https://bugs.gentoo.org/673092 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Dominik Kriegner <dominik.kriegner@gmail.com> Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> app-text/referencer/referencer-1.2.2.ebuild | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-)
