Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 676926 - net-im/dino should depend on >=dev-libs/icu-57.0 - CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message): Could NOT find ICU (missing: ICU_LIBRARY) (Required is at least version "57")
Summary: net-im/dino should depend on >=dev-libs/icu-57.0 - CMake Error at /usr/share/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andriy Utkin (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-30 16:24 UTC by Enne Eziarc
Modified: 2019-02-01 18:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,10.28 KB, text/plain)
2019-01-30 16:24 UTC, Enne Eziarc 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enne Eziarc 2019-01-30 16:24:27 UTC 
Created attachment 563292 [details]
build.log

This dep was slipped in a month ago for a trivial feature ([1]), which IMO doesn't justify adding such a gigantic dependency. If I put together a patch to make it optional, would it be accepted?

[1]: https://github.com/dino/dino/commit/965f4da75ae5a5b308191bd61890b4277504f5b1
Comment 1 Andriy Utkin (RETIRED) gentoo-dev 2019-02-01 18:28:55 UTC 
Hi Anthony!

Thanks for reporting this. I will update the ebuild immediately.

I have asked fiaxh how likely it is for ICU dependency to become more important in future. If the answer will be that ICU won't be relied on too much, then I'd suggest you to submit the optionality patch to upstream. This is because applying patches to a live ebuild is not sustainable - it will break otherwise fine ebuild every now and then, and 9999 is not meant to be "supported" anyway.

My personal perspective is that dev-libs/icu is not that burdensome dependency, I have it listalled on my systems anyway. So unless you're in hard opposition to dev-libs/icu, I'd suggest to give in :)
Comment 2 Larry the Git Cow gentoo-dev 2019-02-01 18:35:23 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a48aa7bf00f8248057cbf4c5c323025fd52b93e1

commit a48aa7bf00f8248057cbf4c5c323025fd52b93e1
Author:     Andrey Utkin <andrey_utkin@gentoo.org>
AuthorDate: 2019-02-01 18:34:25 +0000
Commit:     Andrey Utkin <andrey_utkin@gentoo.org>
CommitDate: 2019-02-01 18:34:25 +0000

    net-im/dino: add dep on dev-libs/icu
    
    Omitted ">= 57.0" part because it's satisfied by every version in
    current Gentoo tree.
    
    Bug: https://bugs.gentoo.org/676926
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Andrey Utkin <andrey_utkin@gentoo.org>

 net-im/dino/dino-9999.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 Andriy Utkin (RETIRED) gentoo-dev 2019-02-01 18:36:58 UTC 
Ebuild updated. Closing.

Thanks again for report Anthony.
Thanks to Jeroen for bug-wrangling.