Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 676696 - www-client/firefox: consider building with --enable-rust-simd
Summary: www-client/firefox: consider building with --enable-rust-simd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-29 06:25 UTC by Georgy Yakovlev
Modified: 2019-01-29 08:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log with --enable-rust-simd (ff-simd-build.log.bz2,703.72 KB, application/x-bzip)
2019-01-29 06:25 UTC, Georgy Yakovlev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2019-01-29 06:25:48 UTC
Created attachment 563166 [details]
build log with --enable-rust-simd

Since pgo was enabled for 65, I did some digging about simd.

How about enabling --enable-rust-simd for 64bit builds, at least on amd64, or maybe put it behind new useflag or existing custom-optimizations?

upstream enables it by default for their builds
https://github.com/mozilla/gecko-dev/commit/9c23847d055a763f21b2867f1014f66c10ade78e

ubuntu also enables it by default starting with ff65.
https://launchpad.net/ubuntu/+source/firefox/65.0+build2-0ubuntu1


passing something like mozconfig_annotate '' --enable-rust-simd;
should do the trick, rust feature will be activated

/usr/bin/cargo rustc  --release --frozen --manifest-path /tmp/portage/www-client/firefox-65.0/work/firefox-65.0/toolkit/library/rust/Cargo.toml --color=always --lib --target=x86_64-unknown-linux-gnu --features "servo bindgen quantum_render >>simd-accel<< cubeb-remoting moz_memory gecko_profiler"
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-29 07:53:02 UTC
Will be enabled (except on i386 and armhf).
Comment 2 Larry the Git Cow gentoo-dev 2019-01-29 08:14:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07afc9622a4dcc374a188a2627b28f3d2efea648

commit 07afc9622a4dcc374a188a2627b28f3d2efea648
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-01-29 08:14:16 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-01-29 08:14:31 +0000

    www-client/firefox: enable --enable-rust-simd
    
    Closes: https://bugs.gentoo.org/676696
    Package-Manager: Portage-2.3.58, Repoman-2.3.12
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-65.0.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)