Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 676644 - media-gfx/shotwell-0.30.2 version bump
Summary: media-gfx/shotwell-0.30.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nicolas Bock
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-28 17:49 UTC by Ulenrich
Modified: 2019-03-17 09:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
git_notification_segfault.patch (git_notification_segfault.patch,4.91 KB, patch)
2019-01-29 16:45 UTC, Ulenrich
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulenrich 2019-01-28 17:49:05 UTC
Webpage https://wiki.gnome.org/Apps/Shotwell
shows the development of shotwell-0.29 got a stable release now!
Comment 1 Ulenrich 2019-01-29 16:45:56 UTC
Created attachment 563196 [details, diff]
git_notification_segfault.patch

Found this git_notification_segfault Patch and applied. But I don't know for sure if this is needed for Gentoo
Comment 2 Ulenrich 2019-01-29 17:00:18 UTC
Simple bumped by 
cp shotwell-0.29.3.ebuild shotwell-0.30.1.ebuild
and used the above patch by eapply_user in src_prepare

After unmasking this longtime profiles/package.mask:
---
# Nicolas Bock <nicolasbock@gentoo.org> (17 Jul 2017)
# Keep shotwell development series masked.
>=media-gfx/shotwell-0.29
---

media-gfx/shotwell-0.30.1 
- compiles fine 
- runs as expected without any errors nor coredump
but this warning in ~/.cache/shotwell/shotwell.log:
---
L 4900 2019-01-29 17:04:03 [WRN] Failed to decode XMP metadata.
L 4900 2019-01-29 17:04:03 [WRN] XMP toolkit support not compiled in.
---
I know I recently disabled an USE flag called "xmp"
Comment 3 Mart Raudsepp gentoo-dev 2019-01-29 21:05:43 UTC
0.29.3 ebuild has numerous issues I have mentioned to Nicolas, but neither of us has had time to work on it, it looks like.
The bump should really be done based on 0.28.x ebuild, not 0.29, as 0.29 ebuild has many runtime-only deps missing, missing SLOT deps, and more.
Comment 4 Ulenrich 2019-02-01 18:34:26 UTC
(In reply to Mart Raudsepp from comment #3)
> 0.29.3 ebuild has numerous issues I have mentioned to Nicolas, but neither
> of us has had time to work on it, it looks like.
> The bump should really be done based on 0.28.x ebuild, not 0.29, as 0.29
> ebuild has many runtime-only deps missing, missing SLOT deps, and more.

Tried it with simple bumping from media-gfx/shotwell-0.28.3 
but there seems to be missing some "make configure":
---
>>> Source prepared.
>>> Configuring source in /tmp/portage/media-gfx/shotwell-0.30.1/work/shotwell-0.30.1 ...
grep: ./configure: No such file or directory
grep: ./configure.*: No such file or directory
grep: ./configure: No such file or directory
grep: ./configure: No such file or directory
grep: ./configure: No such file or directory
grep: ./configure: No such file or directory
grep: ./configure: No such file or directory
 * ERROR: media-gfx/shotwell-0.30.1::pmaci failed (configure phase):
 *   no configure script found
Comment 5 Ulenrich 2019-03-04 13:35:07 UTC
media-gfx/shotwell-0.30.2 needs >dev-lang/vala-0.36.x
--- After emerge error:
../shotwell-0.30.2/plugins/shotwell-publishing/PhotosPublishingPane.vala:78.90-78.113: error: The name `SYNC_CREATE' does not exist in the context of `GLib.Binding'
        existing_album_radio.bind_property("active", existing_albums_combo, "sensitive", GLib.Binding.SYNC_CREATE);
---
I succeeded with media-gfx/shotwell-0.30.2 after upgrading:
[ebuild     U  ] dev-libs/vala-common-0.42.6::gentoo [0.36.15::gentoo] 3.277 KiB
[ebuild  NS    ] dev-lang/vala-0.42.6:0.42::gentoo [0.36.15:0.36::gentoo]
Comment 6 Mart Raudsepp gentoo-dev 2019-03-17 08:54:36 UTC
(In reply to Ulenrich from comment #5)
> media-gfx/shotwell-0.30.2 needs >dev-lang/vala-0.36.x
> --- After emerge error:
> ../shotwell-0.30.2/plugins/shotwell-publishing/PhotosPublishingPane.vala:78.
> 90-78.113: error: The name `SYNC_CREATE' does not exist in the context of
> `GLib.Binding'
>         existing_album_radio.bind_property("active", existing_albums_combo,
> "sensitive", GLib.Binding.SYNC_CREATE);
> ---
> I succeeded with media-gfx/shotwell-0.30.2 after upgrading:
> [ebuild     U  ] dev-libs/vala-common-0.42.6::gentoo [0.36.15::gentoo] 3.277
> KiB
> [ebuild  NS    ] dev-lang/vala-0.42.6:0.42::gentoo [0.36.15:0.36::gentoo]


That's odd, as SYNC_CREATE is rather old and does exist in vala-0.36 provided gobject vapi files. But indeed happens to me too. I will raise the minimum vala version required based on testing what is the lowest in tree that works (0.40 or 0.42).
Comment 7 Larry the Git Cow gentoo-dev 2019-03-17 09:16:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3bb5ad7268d6ded439ca2198a942f67d0100cf68

commit 3bb5ad7268d6ded439ca2198a942f67d0100cf68
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2019-03-17 08:52:47 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2019-03-17 09:10:40 +0000

    media-gfx/shotwell: bump to 0.30.2
    
    Closes: https://bugs.gentoo.org/676644
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 media-gfx/shotwell/Manifest               |  1 +
 media-gfx/shotwell/metadata.xml           | 11 +++--
 media-gfx/shotwell/shotwell-0.30.2.ebuild | 81 +++++++++++++++++++++++++++++++
 profiles/arch/alpha/package.use.mask      |  1 +
 profiles/arch/ia64/package.use.mask       |  4 ++
 profiles/package.mask                     |  2 +-
 6 files changed, 95 insertions(+), 5 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=16017e2ca6518bcb5436210b31d2ddafe6a8cf46

commit 16017e2ca6518bcb5436210b31d2ddafe6a8cf46
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2019-03-17 09:02:55 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2019-03-17 09:10:44 +0000

    media-libs/gexiv2: default enable USE=vala
    
    Various GNOME packages will unconditionally need it (shotwell
    in main tree already does). Default enable it, as it just means
    need of a vala slot at build time.
    
    Bug: https://bugs.gentoo.org/665578
    Bug: https://bugs.gentoo.org/676644
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 media-libs/gexiv2/gexiv2-0.10.10-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e998864780afc2040fc546b5408c2bc96d969b3e

commit e998864780afc2040fc546b5408c2bc96d969b3e
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2019-03-17 09:00:03 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2019-03-17 09:10:42 +0000

    media-gfx/shotwell: remove old masked development versions
    
    The ebuild dependencies in them were rather wrong, missing stuff clearly
    declared in toplevel meson.build too. 0.30 bump was done based on 0.28 +
    full redo from meson.build reading.
    
    Bug: https://bugs.gentoo.org/676644
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 media-gfx/shotwell/Manifest               |  2 --
 media-gfx/shotwell/shotwell-0.29.2.ebuild | 39 -------------------------------
 media-gfx/shotwell/shotwell-0.29.3.ebuild | 39 -------------------------------
 profiles/package.mask                     |  4 ----
 4 files changed, 84 deletions(-)