Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 676618 - media-libs/sdl2-image-2.0.4: compile failure SDL_MAX_SINT32
Summary: media-libs/sdl2-image-2.0.4: compile failure SDL_MAX_SINT32
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-28 07:22 UTC by Robin Johnson
Modified: 2019-01-28 07:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2019-01-28 07:22:17 UTC
Feels like a missing/stale DEPEND.
I presently have libsdl2-2.0.3-r200, and the emerge upgrade plan has libsdl2 coming after libsdl2-image.

/dev/shm/portage/media-libs/sdl2-image-2.0.4/work/SDL2_image-2.0.4/IMG_pnm.c: In function ‘ReadNumber’:
/dev/shm/portage/media-libs/sdl2-image-2.0.4/work/SDL2_image-2.0.4/IMG_pnm.c:94:24: error: ‘SDL_MAX_SINT32’ undeclared (first use in this function); did you mean ‘SDL_TEXTINPUT’?
         if (number >= (SDL_MAX_SINT32 / 10)) {
                        ^~~~~~~~~~~~~~
                        SDL_TEXTINPUT
/dev/shm/portage/media-libs/sdl2-image-2.0.4/work/SDL2_image-2.0.4/IMG_pnm.c:94:24: note: each undeclared identifier is reported only once for each function it appears in
make: *** [Makefile:623: IMG_pnm.lo] Error 1
make: *** Waiting for unfinished jobs....
libtool: compile:  x86_64-pc-linux-gnu-gcc -m32 -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"SDL2_image\" -DVERSION=\"2.0.4\" -DLOAD_JPG=1 -DLOAD_PNG=1 -DLOAD_TIF=1 -DLOAD_BMP=1 -DLOAD_GIF=1 -DLOAD_LBM=1 -DLOAD_PCX=1 -DLOAD_PNM=1 -DLOAD_SVG=1 -DLOAD_TGA=1 -DLOAD_XCF=1 -DLOAD_XPM=1 -DLOAD_XV=1 -I. -I/dev/shm/portage/media-libs/sdl2-image-2.0.4/work/SDL2_image-2.0.4 -I/usr/include/libpng16 -march=native -O2 -pipe -I/usr/include/SDL2 -D_REENTRANT -c /dev/shm/portage/media-libs/sdl2-image-2.0.4/work/SDL2_image-2.0.4/IMG_WIC.c  -fPIC -DPIC -o .libs/IMG_WIC.o
Comment 1 Larry the Git Cow gentoo-dev 2019-01-28 07:35:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ccf46bf544047d02a5357dc2e1b82ee063fc653

commit 5ccf46bf544047d02a5357dc2e1b82ee063fc653
Author:     Robin H. Johnson <robbat2@gentoo.org>
AuthorDate: 2019-01-28 07:33:50 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2019-01-28 07:35:17 +0000

    media-libs/sdl2-image: update libsdl2 dep for compile failure
    
    sdl2-image used SDL_MAX_SINT32, which was only introduced in
    libsdl2-2.0.7. Update [R]DEPEND to ensure successful compliation.
    
    Fixes: https://bugs.gentoo.org/676618
    Package-Manager: Portage-2.3.56, Repoman-2.3.12
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>

 media-libs/sdl2-image/sdl2-image-2.0.3.ebuild | 4 ++--
 media-libs/sdl2-image/sdl2-image-2.0.4.ebuild | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)