Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 676364 - media-sound/mpd-0.21.4-r1: fix meson eclass usage
Summary: media-sound/mpd-0.21.4-r1: fix meson eclass usage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-26 21:43 UTC by William Hubbs
Modified: 2019-02-05 22:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix-meson-eclass-usage.patch (fix-meson-eclass-usage.patch,740 bytes, patch)
2019-01-26 21:44 UTC, William Hubbs
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description William Hubbs gentoo-dev 2019-01-26 21:43:53 UTC
Hi,

this ebuild is the only one in the tree that uses meson_auto_depend, and
there is no reason to use it or set the meson dependency yourself at
this point.

The following patch removes this usage.

You shouldn't have to bump since this is a BDEPEND.

Thanks,

William
Comment 1 William Hubbs gentoo-dev 2019-01-26 21:44:36 UTC
Created attachment 562932 [details, diff]
fix-meson-eclass-usage.patch
Comment 2 Larry the Git Cow gentoo-dev 2019-02-03 21:38:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5df23f6b1670d5e9261431a6b4a0670355067c3d

commit 5df23f6b1670d5e9261431a6b4a0670355067c3d
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2019-02-03 21:36:54 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2019-02-03 21:38:04 +0000

    media-sound/mpd: remove meson_auto_depend usage from 0.24.1-r1
    
    This was approved by zlogene.
    
    Closes: https://bugs.gentoo.org/676364
    Package-Manager: Portage-2.3.59, Repoman-2.3.12
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 media-sound/mpd/mpd-0.21.4-r1.ebuild | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Comment 3 Mart Raudsepp gentoo-dev 2019-02-05 22:36:14 UTC
Your change is technically slightly wrong. eclass doesn't guarantee >dev-util/meson-0.47.1, so after your commit it has a minimum dep on >=meson-0.45.1 only, but the package requires at least 0.47.1 or newer (not sure if 0.47.1 itself would be fine, I suspect that's a typo in old dep atom)