Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 676014 - sys-apps/portage: inherit function should use local ECLASS and __export_funcs_var variables
Summary: sys-apps/portage: inherit function should use local ECLASS and __export_funcs...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 671498
  Show dependency tree
 
Reported: 2019-01-22 01:08 UTC by Zac Medico
Modified: 2019-04-10 04:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2019-01-22 01:08:18 UTC
The inherit function's ECLASS and __export_funcs_var variable usage could be simplified by declaring these as local variables.
Comment 2 Larry the Git Cow gentoo-dev 2019-01-23 04:35:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=6a738002397ab9cfe1ff02571ffb4cddb596544a

commit 6a738002397ab9cfe1ff02571ffb4cddb596544a
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-01-22 03:38:14 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-01-23 02:41:56 +0000

    inherit: use local -x ECLASS (bug 676014)
    
    Use local -x ECLASS, and also make __export_funcs_var a local variable,
    since this is simpler than managing these variables as globals
    (eliminates PECLASS and prev_export_funcs_var variables). As an
    additional benefit, this prevents interference from ebuild variables
    as reported in bug 656354 for the ECLASS variable.
    
    Bug: https://bugs.gentoo.org/656354
    Bug: https://bugs.gentoo.org/676014
    
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/ebuild.sh | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)
Comment 3 Zac Medico gentoo-dev 2019-04-10 04:29:35 UTC
Fixed in portage-2.3.62.