Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675750 - x11-misc/dmenu-4.8: installs files outside of prefix
Summary: x11-misc/dmenu-4.8: installs files outside of prefix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-01-18 04:12 UTC by Susan Wilson
Modified: 2019-01-18 07:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,5.38 KB, text/plain)
2019-01-18 04:13 UTC, Susan Wilson
Details
build.log (build-fail.log,11.06 KB, text/plain)
2019-01-18 04:13 UTC, Susan Wilson
Details
dmenu-4.8.ebuild (dmenu-4.8.ebuild,1.30 KB, text/plain)
2019-01-18 04:15 UTC, Susan Wilson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Susan Wilson 2019-01-18 04:12:09 UTC
Hi,

On gentoo-prefix setup, dmenu package installs multiple files outside of
prefix, which is detected by a QA check

```
 * QA Notice: the following files are outside of the prefix:
 * /usr
 * /usr/bin
 * /usr/bin/stest
 * /usr/bin/dmenu
 * /usr/bin/dmenu_path
 * /usr/bin/dmenu_run
 * /usr/share
 * /usr/share/man
 * /usr/share/man/man1
 * /usr/share/man/man1/dmenu.1
 * /usr/share/man/man1/stest.1
 * ERROR: x11-misc/dmenu-4.8::gentoo failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
```

Reproducible: Always

Steps to Reproduce:
1. try to install dmenu on a prefixed gentoo
Actual Results:  
merge failure

Expected Results:  
successful merge
Comment 1 Susan Wilson 2019-01-18 04:13:13 UTC
Created attachment 561912 [details]
emerge --info
Comment 2 Susan Wilson 2019-01-18 04:13:41 UTC
Created attachment 561914 [details]
build.log
Comment 3 Susan Wilson 2019-01-18 04:15:05 UTC
Created attachment 561916 [details]
dmenu-4.8.ebuild

Here is the fixed ebuild
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2019-01-18 07:49:52 UTC
Comment on attachment 561916 [details]
dmenu-4.8.ebuild

--- dmenu-4.8.ebuild    2018-11-18 11:31:09.924751851 +0100
+++ -   2019-01-18 08:49:29.453625463 +0100
@@ -54,7 +54,7 @@
 }

 src_install() {
-       emake DESTDIR="${D}" PREFIX="/usr" install
+       emake DESTDIR="${D}" PREFIX="${EPREFIX}/usr" install

        save_config config.h
 }
Comment 5 Larry the Git Cow gentoo-dev 2019-01-18 07:54:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46959d1072b4b5ecdf7d6c87e37fb38aba280004

commit 46959d1072b4b5ecdf7d6c87e37fb38aba280004
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-01-18 07:52:15 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-01-18 07:54:27 +0000

    x11-misc/dmenu: Fix PREFIX support
    
    Fixes:  https://bugs.gentoo.org/675750
    Package-Manager: Portage-2.3.56, Repoman-2.3.12
    Signed-off-by: Susan Wilson <susanw@airmail.cc>
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 x11-misc/dmenu/dmenu-4.8.ebuild  | 4 ++--
 x11-misc/dmenu/dmenu-9999.ebuild | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)