Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675366 - dev-libs/spdlog-1.3.0 version bump and related dev-libs/spdlog-9999 fixes
Summary: dev-libs/spdlog-1.3.0 version bump and related dev-libs/spdlog-9999 fixes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: David Roman
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-01-13 23:34 UTC by jospezial
Modified: 2019-01-14 18:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2019-01-13 23:34:43 UTC
https://github.com/gabime/spdlog/releases/tag/v1.3.0

new dependency on google benchmark to test latencies:
https://github.com/gabime/spdlog/commit/da30e2ef18da4570227aaa501673afffa097768d
"Improved CMakeLists and added bench"

https://github.com/gabime/spdlog/commit/47cf62f878cc9c3bb7808154fe063299c9ce91b0
"SPDLOG_BUILD_TESTING now depends on BUILD_TESTING"

diff --git a/dev-libs/spdlog/spdlog-9999.ebuild b/dev-libs/spdlog/spdlog-9999.ebuild
index 03aaec9bd60..71493dde836 100644
--- a/dev-libs/spdlog/spdlog-9999.ebuild
+++ b/dev-libs/spdlog/spdlog-9999.ebuild
@@ -32,7 +32,8 @@ src_configure() {
 
        local mycmakeargs=(
                -DSPDLOG_BUILD_EXAMPLES=no
-               -DSPDLOG_BUILD_TESTING=$(usex test)
+               -DBUILD_TESTING=$(usex test)
+               -DSPDLOG_BUILD_BENCH=no
        )
 
        cmake-utils_src_configure
Comment 1 jospezial 2019-01-13 23:46:31 UTC
https://github.com/gabime/spdlog/commit/0955ea5b8510fdc1784f4f5684728011f129f60d
"Fix handling of external fmt lib"

diff --git a/dev-libs/spdlog/spdlog-9999.ebuild b/dev-libs/spdlog/spdlog-9999.ebuild
index 03aaec9bd60..b80cd85d917 100644
--- a/dev-libs/spdlog/spdlog-9999.ebuild
+++ b/dev-libs/spdlog/spdlog-9999.ebuild
@@ -32,7 +32,9 @@ src_configure() {
 
        local mycmakeargs=(
                -DSPDLOG_BUILD_EXAMPLES=no
-               -DSPDLOG_BUILD_TESTING=$(usex test)
+               -DBUILD_TESTING=$(usex test)
+               -DSPDLOG_BUILD_BENCH=no
+               -DSPDLOG_FMT_EXTERNAL=yes
        )
 
        cmake-utils_src_configure
Comment 2 Larry the Git Cow gentoo-dev 2019-01-14 18:51:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e29bb29e57ff5256371265b0762a6d2256f2a7a

commit 2e29bb29e57ff5256371265b0762a6d2256f2a7a
Author:     David Roman <davidroman96@gmail.com>
AuthorDate: 2019-01-13 12:37:27 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-01-14 18:51:17 +0000

    dev-libs/spdlog: verbump to 1.3.0
    
    Closes: https://bugs.gentoo.org/675366
    Package-Manager: Portage-2.3.55, Repoman-2.3.12
    Signed-off-by: David Roman <davidroman96@gmail.com>
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 dev-libs/spdlog/Manifest            |  1 +
 dev-libs/spdlog/spdlog-1.3.0.ebuild | 40 +++++++++++++++++++++++++++++++++++++
 dev-libs/spdlog/spdlog-9999.ebuild  |  7 ++++---
 3 files changed, 45 insertions(+), 3 deletions(-)