Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675364 - net-ftp/tlswrap-1.04-r3 : tls.c:76:61: error: operator || has no right operand
Summary: net-ftp/tlswrap-1.04-r3 : tls.c:76:61: error: operator || has no right operand
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Deadline: 2021-01-17
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PMASKED
Depends on:
Blocks:
 
Reported: 2019-01-13 21:51 UTC by Toralf Förster
Modified: 2021-01-19 08:42 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.78 KB, text/plain)
2019-01-13 21:51 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,203.59 KB, text/plain)
2019-01-13 21:51 UTC, Toralf Förster
Details
environment (environment,61.38 KB, text/plain)
2019-01-13 21:51 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,14.48 KB, application/x-bzip)
2019-01-13 21:51 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,6.35 KB, application/x-bzip)
2019-01-13 21:51 UTC, Toralf Förster
Details
net-ftp:tlswrap-1.04-r3:20190113-212255.log (net-ftp:tlswrap-1.04-r3:20190113-212255.log,11.57 KB, text/plain)
2019-01-13 21:51 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,19.14 KB, application/x-bzip)
2019-01-13 21:51 UTC, Toralf Förster
Details
emerge-info.txt (emerge-info.txt,15.28 KB, text/plain)
2019-01-16 19:52 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,137.41 KB, text/plain)
2019-01-16 19:52 UTC, Toralf Förster
Details
environment (environment,61.08 KB, text/plain)
2019-01-16 19:53 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,13.70 KB, application/x-bzip)
2019-01-16 19:53 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,6.27 KB, application/x-bzip)
2019-01-16 19:53 UTC, Toralf Förster
Details
net-ftp:tlswrap-1.04-r3:20190116-195032.log (net-ftp:tlswrap-1.04-r3:20190116-195032.log,13.67 KB, text/plain)
2019-01-16 19:53 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,19.57 KB, application/x-bzip)
2019-01-16 19:53 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2019-01-13 21:51:09 UTC
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -Wall -Wmissing-prototypes   -O2 -pipe -march=native -I/usr/include -c -o tlswrap-tls.o `test -f 'tls.c' || echo './'`tls.c
tls.c: In function ‘tls_init’:
tls.c:76:61: error: operator '||' has no right operand
 #if (OPENSSL_VERSION_NUMBER < 0x10100000L) || OPENSSL_NO_EGD
                                                             ^
tls.c: In function ‘tls_cert2’:

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-systemd_20190110-191026

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-8.2.0 *

Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.6
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems) *
  [2]   ruby25 (with Rubygems)
  [3]   ruby26 (with Rubygems)
Available Rust versions:
  [1]   rust-bin-1.31.1 *



emerge -qpvO net-ftp/tlswrap
[ebuild  N    ] net-ftp/tlswrap-1.04-r3  USE="-libressl"
Comment 1 Toralf Förster gentoo-dev 2019-01-13 21:51:12 UTC
Created attachment 560916 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2019-01-13 21:51:15 UTC
Created attachment 560918 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2019-01-13 21:51:17 UTC
Created attachment 560920 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2019-01-13 21:51:20 UTC
Created attachment 560922 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2019-01-13 21:51:23 UTC
Created attachment 560924 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2019-01-13 21:51:26 UTC
Created attachment 560926 [details]
net-ftp:tlswrap-1.04-r3:20190113-212255.log
Comment 7 Toralf Förster gentoo-dev 2019-01-13 21:51:29 UTC
Created attachment 560928 [details]
temp.tbz2
Comment 8 Pacho Ramos gentoo-dev 2019-01-14 21:18:32 UTC
in my case it builds fine with that :/
Comment 9 Toralf Förster gentoo-dev 2019-01-16 19:52:52 UTC
got at the unstable amd64 chroot image 17.0-no-multilib-hardened_libressl-test_20190113-153406 this too
Comment 10 Toralf Förster gentoo-dev 2019-01-16 19:52:54 UTC
Created attachment 561600 [details]
emerge-info.txt
Comment 11 Toralf Förster gentoo-dev 2019-01-16 19:52:58 UTC
Created attachment 561602 [details]
emerge-history.txt
Comment 12 Toralf Förster gentoo-dev 2019-01-16 19:53:00 UTC
Created attachment 561604 [details]
environment
Comment 13 Toralf Förster gentoo-dev 2019-01-16 19:53:03 UTC
Created attachment 561606 [details]
etc.portage.tbz2
Comment 14 Toralf Förster gentoo-dev 2019-01-16 19:53:06 UTC
Created attachment 561608 [details]
logs.tbz2
Comment 15 Toralf Förster gentoo-dev 2019-01-16 19:53:08 UTC
Created attachment 561610 [details]
net-ftp:tlswrap-1.04-r3:20190116-195032.log
Comment 16 Toralf Förster gentoo-dev 2019-01-16 19:53:11 UTC
Created attachment 561612 [details]
temp.tbz2
Comment 17 Tamas Jantvik 2019-10-08 18:36:39 UTC
Changing line 8 of files/tlswrap-1.04-openssl11.patch from

+#if (OPENSSL_VERSION_NUMBER < 0x10100000L) || OPENSSL_NO_EGD

to

+#if (OPENSSL_VERSION_NUMBER < 0x10100000L) || !defined(OPENSSL_NO_EGD)

makes it compile on my systems, on which I hit this today when upgrading to openssl v1.1
Comment 18 Agostino Sarubbo gentoo-dev 2020-10-30 08:33:47 UTC
Dear treecleaner@:

I'm still able to reproduce this issue right now.

Since it has not been fixed for a long time, I'd suggest to evaluate if it is the case to remove this package from the tree. Thanks
Comment 19 Larry the Git Cow gentoo-dev 2020-12-18 10:17:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=003db2626e8b775dc5884d488b4aadafa84f92d6

commit 003db2626e8b775dc5884d488b4aadafa84f92d6
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-12-18 10:05:23 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-12-18 10:17:02 +0000

    package.mask: Last rite net-ftp/tlswrap
    
    Bug: https://bugs.gentoo.org/675364
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 20 Tamas Jantvik 2020-12-19 16:39:36 UTC
This still compiles on my system with the previously suggested patch. It's a nice tool for integrating legacy business support systems supporting only FTP with FTPES servers for secure file transfers. But I can of course just put it in my local overlay.
Comment 21 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-12-19 17:50:22 UTC
This is not the first time this package is broken by new OpenSSL, and certainly not the last time either.  Keeping it requires a dedicated maintainer (dev or proxied) who is going to fix it in the future whenever it happens.
Comment 22 Larry the Git Cow gentoo-dev 2021-01-19 08:42:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed9d3833c1919f53c2e3fb9f71dd1e472a768cdf

commit ed9d3833c1919f53c2e3fb9f71dd1e472a768cdf
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-01-19 08:40:01 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-01-19 08:40:01 +0000

    net-ftp/tlswrap: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/675364
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 net-ftp/tlswrap/Manifest                           |  1 -
 .../files/fix-Wformat-security-warnings.patch      | 67 ----------------------
 .../tlswrap/files/modernize-am_init_automake.patch | 30 ----------
 net-ftp/tlswrap/files/respect-cflags.patch         | 66 ---------------------
 net-ftp/tlswrap/files/tlswrap-1.04-openssl11.patch | 60 -------------------
 net-ftp/tlswrap/files/tlswrap.init                 | 19 ------
 net-ftp/tlswrap/metadata.xml                       |  5 --
 net-ftp/tlswrap/tlswrap-1.04-r3.ebuild             | 39 -------------
 profiles/package.mask                              |  6 --
 9 files changed, 293 deletions(-)