Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 675176 - media-video/ffmpeg - add conditional support for media-libs/vidstab
Summary: media-video/ffmpeg - add conditional support for media-libs/vidstab
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2019-01-11 11:02 UTC by Helmut Jarausch
Modified: 2019-02-20 15:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ffmpeg-4.1.ebuild (ffmpeg-4.1.ebuild,16.73 KB, text/plain)
2019-01-11 11:02 UTC, Helmut Jarausch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2019-01-11 11:02:03 UTC
Created attachment 560672 [details]
ffmpeg-4.1.ebuild

I've attached a modified ebuild which recognizes the vidstab USE flag
and configures ffmpeg to use libvidstab
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-01-12 09:09:43 UTC
Comment on attachment 560672 [details]
ffmpeg-4.1.ebuild

--- ffmpeg-4.1.ebuild   2018-12-23 14:07:30.070632812 +0100
+++ -   2019-01-12 10:08:47.575251777 +0100
@@ -98,7 +98,7 @@
 )

 IUSE="
-       alsa chromium doc +encode oss pic static-libs test v4l
+       alsa chromium doc +encode oss pic static-libs test v4l vidstab
        ${FFMPEG_FLAG_MAP[@]%:*}
        ${FFMPEG_ENCODER_FLAG_MAP[@]%:*}
 "
@@ -235,6 +235,7 @@
        truetype? ( >=media-libs/freetype-2.5.0.1:2[${MULTILIB_USEDEP}] )
        vaapi? ( >=x11-libs/libva-1.2.1-r1[${MULTILIB_USEDEP}] )
        video_cards_nvidia? ( >=media-libs/nv-codec-headers-8.1.24.2[${MULTILIB_USEDEP}] )
+       vidstab? ( media-libs/vidstab[${MULTILIB_USEDEP}] )
        vdpau? ( >=x11-libs/libvdpau-0.7[${MULTILIB_USEDEP}] )
        vorbis? (
                >=media-libs/libvorbis-1.3.3-r1[${MULTILIB_USEDEP}]
@@ -358,6 +359,7 @@
        use amr && myconf+=( --enable-version3 )
        use gmp && myconf+=( --enable-version3 )
        use fdk && use gpl && myconf+=( --enable-nonfree )
+       use vidstab && myconf+=( --enable-libvidstab )

        for i in "${ffuse[@]#+}" ; do
                myconf+=( $(use_enable ${i%:*} ${i#*:}) )
Comment 2 Kalin KOZHUHAROV 2019-01-12 10:12:19 UTC
That is a duplicate of bug #517890, and I just did a PR (https://github.com/gentoo/gentoo/pull/10810) for it.

Better use the logic in the ebuild instead of "myconf+=( --enable-libvidstab )", in FFMPEG_FLAG_MAP.
Comment 3 Larry the Git Cow gentoo-dev 2019-02-20 15:21:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=473c374441108c1dee3cc752fcad3ece19be8209

commit 473c374441108c1dee3cc752fcad3ece19be8209
Author:     Kalin KOZHUHAROV <me.kalin@gmail.com>
AuthorDate: 2018-05-15 12:06:23 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2019-02-20 15:21:38 +0000

    media-video/ffmpeg: add USE=vidstab
    
    Closes: https://bugs.gentoo.org/517890
    Closes: https://bugs.gentoo.org/675176
    
    Signed-off-by: Kalin KOZHUHAROV <kalin@thinrope.net>
    Signed-off-by: Kalin KOZHUHAROV <me.kalin@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/10810
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-video/ffmpeg/ffmpeg-9999.ebuild | 3 ++-
 media-video/ffmpeg/metadata.xml       | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)