Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674788 - dev-cpp/sourcetrail: please consider adjusting dev-libs/openssl dependency
Summary: dev-cpp/sourcetrail: please consider adjusting dev-libs/openssl dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: David Hallas
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-01-07 16:38 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2019-02-04 13:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-01-07 16:38:37 UTC
Current dependency for openssl in the ebuild looks like this:

  dev-libs/openssl

This neither handles slots dependencies nor sub-slot dependencies.
Considering this being a binary package I doubt that the package works with all
different versions of openssl.

IMHO there are two solutions for this.

1.)
Either the package will work with all available openssl versions, then you
should adjust the dependency to

  dev-libs/openssl:*


2.)
Or you "pin" the package to a specific openssl version:

  =dev-libs/openssl-1.0*:*

or

  =dev-libs/openssl-0.9.8*:*


I believe that option 2.) is the better solution because a binary package
usually expects a specific openssl version to be installed.
Comment 1 David Hallas 2019-01-08 15:33:41 UTC
Good catch :)

I can see from the binaries that the package is built against OpenSSL-1.0.1e so I think pinning it to =dev-libs/openssl-1.0*:* is the way to go. I have created a PR with the change.
Comment 2 Larry the Git Cow gentoo-dev 2019-02-04 13:42:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07fad24c94cfa6f66609acf2647720976d6522d5

commit 07fad24c94cfa6f66609acf2647720976d6522d5
Author:     David Hallas <david@davidhallas.dk>
AuthorDate: 2019-01-11 07:06:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2019-02-04 13:41:00 +0000

    dev-cpp/sourcetrail: Adjust openssl dependency
    
    Adjust openssl dependency to depend on =dev-libs/openssl-1.0*:*.
    The Sourcetrail package is built agains openssl-1.0.1 so depending
    on =dev-libs/openssl-1.0*:0 should match the correct version.
    
    Closes: https://bugs.gentoo.org/674788
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: David Hallas <david@davidhallas.dk>
    Closes: https://github.com/gentoo/gentoo/pull/10777
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../sourcetrail/sourcetrail-2018.3.55-r1.ebuild    | 89 ++++++++++++++++++++++
 1 file changed, 89 insertions(+)