Created attachment 560178 [details, diff] fix unescaped braces in webdavcgi-1.1.1 for perl-5.26 webdavcgi-1.1.1 is broken with perl-5.26 because of unescaped braces in regex. The issue seems to be fixed in upstream: https://github.com/DanRohde/webdavcgi/commit/04e79b7ecbaf3aae5ab813cd4fc0a009c72b1580 Till version bump (https://bugs.gentoo.org/658470) I fixed the braces for webdavcgi-1.1.1. See attached patch that works for me.
I encourage the maintainer of this package to do something so that some sort of useful tests execute with FEATURES="test" My huge test run did find and test this package[1], but nothing failed with FEATURES="test", and so this package being broken wasn't discovered until somebody was affected, which is very sub-par. Please put in some effort to make it so that in situations like this, src_test *would* fail, so that future test sweeps provide useful fault detection. 1: https://github.com/kentfredric/gentoo-perl-triage/blame/5.28.0/index/www-apps-w#L5
(In reply to Alexander Weber from comment #0) > webdavcgi-1.1.1 is broken with perl-5.26 because of unescaped braces in > regex. > > The issue seems to be fixed in upstream: > https://github.com/DanRohde/webdavcgi/commit/ > 04e79b7ecbaf3aae5ab813cd4fc0a009c72b1580 > > Till version bump (https://bugs.gentoo.org/658470) I fixed the braces for > webdavcgi-1.1.1. See attached patch that works for me. thanks a lot for the report and the proposed regex patch. The PR is available on GitHub: https://github.com/gentoo/gentoo/pull/10826 (In reply to Kent Fredric (IRC: kent\n) from comment #1) > I encourage the maintainer of this package to do something so that some sort > of useful tests execute with FEATURES="test" would you have some proposal on what you expect in this case? Perhaps a good example from another ebuild? The upsteam project itself, doesn't seems to provide built-in test cases. Thanks.
Not a 5.28 regression
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1f48c31817d15862ca180e32f4449117c49e87a commit d1f48c31817d15862ca180e32f4449117c49e87a Author: Christian Affolter <c.affolter@purplehaze.ch> AuthorDate: 2019-01-13 15:39:08 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-01-05 08:39:13 +0000 www-apps/webdavcgi: Version bump to 1.1.2 Add fix unescaped braces patch. This patch fixes the unescaped brace regex warnings, which break the usage of WebDAV CGI with Perl >= 5.26 as reported by Alexander Weber within #674772 and #658470. It is based on: https://github.com/DanRohde/webdavcgi/commit/04e79b7ecbaf3aae5ab813cd4fc0a009c72b1580 Apart from the version bump, the following enhancements were made: * Use EAPI 7 * Updated home page and external links of the WebDAV CGI project. * Depend on dev-perl/IO-Compress-Brotli, which is required for 1.1.2. * Fix unescaped braces (addresses #674772 and #658470) * Add note regarding systemd and setuid/setgid webdavwrapper * Using EROOT instead of ROOT for displaying installation paths * Removed no longer used eutils dependency Closes: https://bugs.gentoo.org/658470 Closes: https://bugs.gentoo.org/674772 Signed-off-by: Christian Affolter <c.affolter@purplehaze.ch> Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-apps/webdavcgi/Manifest | 1 + .../files/apache-webdavcgi-1.1-example.conf | 7 +- .../webdavcgi-1.1.2-fix-unescaped-braces.patch | 98 ++++++++++ www-apps/webdavcgi/webdavcgi-1.1.2.ebuild | 206 +++++++++++++++++++++ 4 files changed, 309 insertions(+), 3 deletions(-)
