Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674504 - www-client/chromium - SafeBrowsing does not work
Summary: www-client/chromium - SafeBrowsing does not work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-04 13:05 UTC by vm666
Modified: 2019-03-17 20:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vm666 2019-01-04 13:05:00 UTC
SafeBrowsing works with the binary package www-client/google-chrome, but it does not work if the browser is recompiled from the source package www-client/chromium

SafeBrowsing can be tested on https://testsafebrowsing.appspot.com/
At least, the option should be greyed out to inform the user that the feature is not available.


See also: https://forums.gentoo.org/viewtopic-p-8273008.html

NB: same problem with firefox and firefox-bin. See bug 674502.
Comment 1 Mike Gilbert gentoo-dev 2019-01-23 18:26:50 UTC
Lei Zhang at Google says this should be fixed. Can you confirm?
Comment 2 vm666 2019-01-23 18:50:24 UTC
I still have the problem. Am I supposed to do something to fix the problem? (e.g. recompile chromium)
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2019-01-29 22:13:32 UTC
No, no recompilation is necessary. The question is if your browser just didn't try to fetch SafeBrowsing data again or if it tried and failed. I don't know how you tell Chromium to update SafeBrowsing data. Maybe it is enough to delete the "Safe Browsing" folder and files in your profile's folder to trigger an update.
Comment 4 vm666 2019-01-31 10:39:21 UTC
I created a new profile with:
chromium --user-data-dir=/tmp/foo

SafeBrowsing does not work.

Just in case, I recompiled it and it still does not work.
Comment 5 Maciej S. Szmigiero 2019-03-11 13:23:27 UTC
Can confirm this issue with
www-client/chromium-73.0.3683.27 (current latest in the tree).
Comment 6 Maciej S. Szmigiero 2019-03-13 20:50:51 UTC
It seems this is a Chromium bug after all.

They have a signedness bug in their
std::char_traits<char>::compare() reimplementation.

clang compiled www-client/chromium probably isn't affected
as it specifically uses a different code path.

Also, not every (Safe Browsing-flagged) site is affected,
it depends on a particular URL hash and exact SB list content.
Currently, one of affected addresses is
"https://testsafebrowsing.appspot.com/s/phishing.html"

Reported as https://crbug.com/941696 and attached
"chromium-fix-char_traits.patch" patch there which fixes
the issue for me.
Comment 7 Larry the Git Cow gentoo-dev 2019-03-17 20:51:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3689dcb0330fdf694a3655b05732c0b14527ad42

commit 3689dcb0330fdf694a3655b05732c0b14527ad42
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2019-03-17 20:50:47 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2019-03-17 20:51:21 +0000

    www-client/chromium: apply fix for SafeBrowsing
    
    Thanks to Maciej S. Szmigiero for the patch.
    
    Closes: https://bugs.gentoo.org/674504
    Package-Manager: Portage-2.3.62, Repoman-2.3.12_p83
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 www-client/chromium/chromium-73.0.3683.75.ebuild         |  1 +
 www-client/chromium/files/chromium-fix-char_traits.patch | 14 ++++++++++++++
 2 files changed, 15 insertions(+)